fix(updater): use msiexec to install .msi updates#1454
Conversation
Package Changes Through 2d8e89fThere are 6 changes which include notification with prerelease, deep-link-js with prerelease, http with prerelease, http-js with prerelease, sql with prerelease, updater with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
One thing i just noticed because of your nsis_installer_args change is that we never ported the std::env::args change to the v2 msi updater. Maybe we can use a public property for that to tell the msi about them (doesn't have to be this pr). On that note, can it even restart the app right now? We've used powershell for that in the past. Just on my phone rn so didn't test anything (including this pr) |
|
The restart thing (and consecutively the current args) and the upgrade using TaskScheduler, were removed because we don't use powershell anymore. This is out of this PR scope, so I'd rather discuss this on Discord or in another issue but the generated installer should have a flag or something that could be used to launch the application afterwards. I am not sure if it is possible but we plan to phase out msi installer anyways since no one in the team really wants to maintain it so might not worth the effort. |
FabianLars
left a comment
FabianLars
left a comment
There was a problem hiding this comment.
still didn't test it but can't be worse than the current version and the code looks good to me 🤷
|
when publish the next version |
|
Hmm I still can't |
4 participants
closes #1449