Skip to content

feat(macos): allow to disable system tray menu on left click, closes #317#329

Merged
amrbashir merged 6 commits into
devfrom
fix/macos/tray-menu
Jun 9, 2022
Merged

feat(macos): allow to disable system tray menu on left click, closes #317#329
amrbashir merged 6 commits into
devfrom
fix/macos/tray-menu

Conversation

@amrbashir
Copy link
Copy Markdown
Member

@amrbashir amrbashir commented Feb 28, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team February 28, 2022 17:05
@amrbashir amrbashir requested a review from a team as a code owner February 28, 2022 17:05
@amrbashir amrbashir changed the title fix(macos): show system tray menu on right click only fix(macos): show system tray menu on right click only, closes #317 Feb 28, 2022
@amrbashir amrbashir closed this Apr 2, 2022
@amrbashir amrbashir deleted the fix/macos/tray-menu branch April 2, 2022 10:37
@amrbashir amrbashir restored the fix/macos/tray-menu branch April 29, 2022 15:04
@amrbashir amrbashir reopened this Apr 29, 2022
@amrbashir amrbashir requested a review from wusyong May 22, 2022 19:00
@wusyong
Copy link
Copy Markdown
Member

wusyong commented May 23, 2022

I think I mentioned that default tray supports both clicks too.
If we really want to specify certain behaviour, I guess we expose a method for extension trait.

@amrbashir
Copy link
Copy Markdown
Member Author

amrbashir commented May 23, 2022

A lot of users asked for this behaviour, check the linked issue and this one tauri-apps/tauri#4002 and some on discord too.

@wusyong
Copy link
Copy Markdown
Member

wusyong commented May 23, 2022

I know, but as I stated in #317 even official trays works on both or even just left click.
Supporting both clicks is the sensible default. User won't get confused on first try.
If we really want to specify only one kind of click, it should be a extension trait method IMHO.

@amrbashir
Copy link
Copy Markdown
Member Author

Alright, a trait extension sounds good.

@amrbashir
Copy link
Copy Markdown
Member Author

I attempted to make it as a trait extension but becaue of my lack of macOS development skill, I couldn't finish it. @wusyong whenever you have some time, could u look into this? I added a TODO where the value should be read.

Comment thread src/platform/macos.rs
@amrbashir amrbashir changed the title fix(macos): show system tray menu on right click only, closes #317 fix(macos): allow to show system tray menu on right click only, closes #317 Jun 9, 2022
@amrbashir amrbashir changed the title fix(macos): allow to show system tray menu on right click only, closes #317 fix(macos): allow to disable system tray menu on left click, closes #317 Jun 9, 2022
@amrbashir amrbashir changed the title fix(macos): allow to disable system tray menu on left click, closes #317 feat(macos): allow to disable system tray menu on left click, closes #317 Jun 9, 2022
@amrbashir amrbashir merged commit 0858356 into dev Jun 9, 2022
@amrbashir amrbashir deleted the fix/macos/tray-menu branch June 9, 2022 12:49
@github-actions github-actions Bot mentioned this pull request Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants