You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
amrbashir
changed the title
fix(macos): show system tray menu on right click only
fix(macos): show system tray menu on right click only, closes #317
Feb 28, 2022
I think I mentioned that default tray supports both clicks too.
If we really want to specify certain behaviour, I guess we expose a method for extension trait.
I know, but as I stated in #317 even official trays works on both or even just left click.
Supporting both clicks is the sensible default. User won't get confused on first try.
If we really want to specify only one kind of click, it should be a extension trait method IMHO.
I attempted to make it as a trait extension but becaue of my lack of macOS development skill, I couldn't finish it. @wusyong whenever you have some time, could u look into this? I added a TODO where the value should be read.
amrbashir
changed the title
fix(macos): show system tray menu on right click only, closes #317
fix(macos): allow to show system tray menu on right click only, closes #317
Jun 9, 2022
amrbashir
changed the title
fix(macos): allow to show system tray menu on right click only, closes #317
fix(macos): allow to disable system tray menu on left click, closes #317
Jun 9, 2022
amrbashir
changed the title
fix(macos): allow to disable system tray menu on left click, closes #317
feat(macos): allow to disable system tray menu on left click, closes #317
Jun 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information