Skip to content

Pull dead workers #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atomizer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pull dead workers #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions workerpool/workerpool.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ IN THE SOFTWARE.
var sys = require("sys");
var child_process = require("child_process");

function Worker (workerScript) {
function Worker (workerScript, pool) {
this.workerScript = workerScript;
this.process = child_process.spawn("node", [this.workerScript]);
var self = this;
Expand All @@ -35,6 +35,8 @@ function Worker (workerScript) {
});
this.process.addListener('exit', function (code) {
sys.debug('worker process exited with code ' + code);
if (pool.pullWorker(self, pool.activeWorkers) || pool.pullWorker(self, pool.idleWorkers))
sys.debug('manual pull');
if (self.timer) {
clearTimeout(self.timer);
self.timer = null;
Expand Down Expand Up @@ -157,7 +159,7 @@ WorkerPool.prototype.checkMaxWorkers = function WorkerPool$checkMaxWorkers () {
}
WorkerPool.prototype.addWorker = function WorkerPool$addWorker() {
if ((this.idleWorkers.length + this.activeWorkers.length) < this.options.maxWorkers)
this.idleWorkers.push(new Worker(this.workerScript));
this.idleWorkers.push(new Worker(this.workerScript, this));
}
WorkerPool.prototype.getWorker = function WorkerPool$getWorker () {
if (!this.idleWorkers.length)
Expand Down