Add additional test cases for RegExp modifiers#4321
Merged
Conversation
Contributor
Author
graphemecluster
commented
Nov 10, 2024
Contributor
Author
There was a problem hiding this comment.
This file is originally identical to nesting-add-ignoreCase-within-remove-ignoreCase.js, which is probably unintended.
JLHwung
approved these changes
Nov 12, 2024
Contributor
JLHwung
left a comment
JLHwung
left a comment
There was a problem hiding this comment.
LGTM, thank you for providing new tests.
Ms2ger
force-pushed
the
regexp-modifiers
branch
2 times, most recently
from
64c6b65 to
49ef392
Compare
Ms2ger
force-pushed
the
regexp-modifiers
branch
from
49ef392 to
1e0d541
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is motivated by a bug discovered in both V8 and SpiderMonkey.
Follow up of #3960.