Skip to content

style: simplify generics in NIP01 builder #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tcheeric merged 2 commits into from
Oct 14, 2025
Merged

style: simplify generics in NIP01 builder #486

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00870ac
style: use diamond operator in NIP01 builder
tcheeric Oct 14, 2025
38b1639
Merge branch 'chore/bump-version-1.0.2-SNAPSHOT' into codex/address-c…
tcheeric Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 6 additions & 31 deletions nostr-java-api/src/main/java/nostr/api/nip01/NIP01EventBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,24 +36,12 @@ public GenericEvent buildTextNote(Identity sender, String content) {
}

public GenericEvent buildRecipientTextNote(String content, List<PubKeyTag> tags) {
return buildRecipientTextNote(null, content, tags);
}

public GenericEvent buildRecipientTextNote(
Identity sender, String content, List<PubKeyTag> tags) {
return new GenericEventFactory<PubKeyTag>(
resolveSender(sender), Kind.TEXT_NOTE.getValue(), tags, content)
return new GenericEventFactory<>(resolveSender(null), Kind.TEXT_NOTE.getValue(), tags, content)
.create();
}

public GenericEvent buildTaggedTextNote(@NonNull List<BaseTag> tags, @NonNull String content) {
return buildTaggedTextNote(null, tags, content);
}

public GenericEvent buildTaggedTextNote(
Identity sender, @NonNull List<BaseTag> tags, @NonNull String content) {
return new GenericEventFactory<BaseTag>(
resolveSender(sender), Kind.TEXT_NOTE.getValue(), tags, content)
return new GenericEventFactory<>(resolveSender(null), Kind.TEXT_NOTE.getValue(), tags, content)
.create();
}

Expand Down Expand Up @@ -84,18 +72,12 @@ public GenericEvent buildReplaceableEvent(
return buildReplaceableEvent(null, tags, kind, content);
}

public GenericEvent buildReplaceableEvent(
Identity sender, List<BaseTag> tags, Integer kind, String content) {
return new GenericEventFactory<BaseTag>(resolveSender(sender), kind, tags, content).create();
public GenericEvent buildReplaceableEvent(List<BaseTag> tags, Integer kind, String content) {
return new GenericEventFactory<>(resolveSender(null), kind, tags, content).create();
}

public GenericEvent buildEphemeralEvent(List<BaseTag> tags, Integer kind, String content) {
return buildEphemeralEvent(null, tags, kind, content);
}

public GenericEvent buildEphemeralEvent(
Identity sender, List<BaseTag> tags, Integer kind, String content) {
return new GenericEventFactory<BaseTag>(resolveSender(sender), kind, tags, content).create();
return new GenericEventFactory<>(resolveSender(null), kind, tags, content).create();
}

public GenericEvent buildEphemeralEvent(Integer kind, String content) {
Expand All @@ -117,14 +99,7 @@ public GenericEvent buildAddressableEvent(

public GenericEvent buildAddressableEvent(
@NonNull List<GenericTag> tags, @NonNull Integer kind, String content) {
return buildAddressableEvent(null, tags, kind, content);
}

public GenericEvent buildAddressableEvent(
Identity sender, @NonNull List<GenericTag> tags, @NonNull Integer kind, String content) {
return new GenericEventFactory<GenericTag>(
resolveSender(sender), kind, tags, content)
.create();
return new GenericEventFactory<>(resolveSender(null), kind, tags, content).create();
}

private Identity resolveSender(Identity override) {
Expand Down