Conversation
- Corrected the reference to the builder class for JsonDeserialize annotation in CalendarRsvpContent to ensure proper deserialization.
- Bump the project version from 1.0.0 to 1.0.1 across all modules. - Add explicit names for each artifact in the pom.xml for clarity.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| <scm> | ||
| <connection>scm:git:git://github.com/tcheeric/nostr-java.git</connection> | ||
| <developerConnection>scm:git:ssh://github.com:tcheeric/nostr-java.git</developerConnection> | ||
| <url>https://github.com/tcheeric/nostr-java/tree/main</url> |
There was a problem hiding this comment.
Fix malformed Maven SCM developerConnection
The newly added <developerConnection> uses scm:git:ssh://github.com:tcheeric/nostr-java.git, which is not a valid SSH URL because the portion after github.com: is treated as a port rather than the repository path. Maven release plugins and Sonatype Central metadata validation rely on this field and will fail to clone or tag the repo with the current value. Use the canonical form (scm:git:ssh://git@github.com/tcheeric/nostr-java.git or scm:git:git@github.com:tcheeric/nostr-java.git) so publishing workflows can resolve the repository correctly.
Useful? React with 👍 / 👎.
Summary
This pull request incorporates updates to the Maven release and repository configuration to enhance consistency and alignment with Sonatype Central standards. Additionally, it introduces refactorings to the API for improved maintainability and usability.
What changed?
JsonDeserializebuilder references to ensure proper deserialization.senderparameter, breaking backward compatibility to favor a streamlined API.BREAKING
CENTRAL_USERNAMEandCENTRAL_PASSWORDenvironment variables for deployments.senderparameter. Users must migrate to the instance-configured sender pattern.Review focus
Focus on:
Checklist