Merged
Conversation
src/libcmis/ws-versioningservice.cxx:70:58: performance: Function parameter 'repoId' should be passed by const reference. [passedByValue] src/libcmis/ws-versioningservice.cxx:70:73: performance: Function parameter 'documentId' should be passed by const reference. [passedByValue] src/libcmis/ws-versioningservice.cxx:91:48: performance: Function parameter 'repoId' should be passed by const reference. [passedByValue] src/libcmis/ws-versioningservice.cxx:91:63: performance: Function parameter 'documentId' should be passed by const reference. [passedByValue] src/libcmis/ws-versioningservice.cxx:121:74: performance: Function parameter 'repoId' should be passed by const reference. [passedByValue] src/libcmis/ws-versioningservice.cxx:121:89: performance: Function parameter 'objectId' should be passed by const reference. [passedByValue] src/libcmis/xml-utils.cxx:344:63: performance: Function parameter 'req' should be passed by const reference. [passedByValue] src/libcmis/xml-utils.cxx:390:52: performance: Function parameter 'dateTimeStr' should be passed by const reference. [passedByValue] src/libcmis/xml-utils.cxx:469:28: performance: Function parameter 'boolStr' should be passed by const reference. [passedByValue] src/libcmis/xml-utils.cxx:481:31: performance: Function parameter 'intStr' should be passed by const reference. [passedByValue] src/libcmis/xml-utils.cxx:500:32: performance: Function parameter 'doubleStr' should be passed by const reference. [passedByValue] src/libcmis/xml-utils.cxx:562:27: performance: Function parameter 'str' should be passed by const reference. [passedByValue] src/libcmis/xml-utils.cxx:568:29: performance: Function parameter 'str' should be passed by const reference. [passedByValue]
caolanm
approved these changes
Mar 3, 2024
dtardon
reviewed
Mar 4, 2024
Contributor
dtardon
left a comment
dtardon
left a comment
There was a problem hiding this comment.
The changes in xml-utils.hxx break ABI. I don't think a minor optimization is a sufficient reason for doing that.
Contributor
Author
|
Contributor
|
Maybe could take the opportunity to change boost::shared_ptr to contemporary std:: equivalents and bump api/abi? At which point might as well make this change anyway? #64 for that thought, feel free to dismiss and keep things as they are :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/libcmis/ws-versioningservice.cxx:70:58: performance: Function parameter 'repoId' should be passed by const reference. [passedByValue]
src/libcmis/ws-versioningservice.cxx:70:73: performance: Function parameter 'documentId' should be passed by const reference. [passedByValue]
src/libcmis/ws-versioningservice.cxx:91:48: performance: Function parameter 'repoId' should be passed by const reference. [passedByValue]
src/libcmis/ws-versioningservice.cxx:91:63: performance: Function parameter 'documentId' should be passed by const reference. [passedByValue]
src/libcmis/ws-versioningservice.cxx:121:74: performance: Function parameter 'repoId' should be passed by const reference. [passedByValue]
src/libcmis/ws-versioningservice.cxx:121:89: performance: Function parameter 'objectId' should be passed by const reference. [passedByValue]
src/libcmis/xml-utils.cxx:344:63: performance: Function parameter 'req' should be passed by const reference. [passedByValue]
src/libcmis/xml-utils.cxx:390:52: performance: Function parameter 'dateTimeStr' should be passed by const reference. [passedByValue]
src/libcmis/xml-utils.cxx:469:28: performance: Function parameter 'boolStr' should be passed by const reference. [passedByValue]
src/libcmis/xml-utils.cxx:481:31: performance: Function parameter 'intStr' should be passed by const reference. [passedByValue]
src/libcmis/xml-utils.cxx:500:32: performance: Function parameter 'doubleStr' should be passed by const reference. [passedByValue]
src/libcmis/xml-utils.cxx:562:27: performance: Function parameter 'str' should be passed by const reference. [passedByValue]
src/libcmis/xml-utils.cxx:568:29: performance: Function parameter 'str' should be passed by const reference. [passedByValue]