Skip to content

Unbreak the build: use std::isfinite#18

Merged
tdhock merged 1 commit intotdhock:masterfrom
barracuda156:fix_isfinite
Sep 10, 2023
Merged

Unbreak the build: use std::isfinite#18
tdhock merged 1 commit intotdhock:masterfrom
barracuda156:fix_isfinite

Conversation

@barracuda156
Copy link
Copy Markdown
Contributor

Fixes: #17

@barracuda156
Copy link
Copy Markdown
Contributor Author

CI failures unrelated to the PR.

@tdhock
Copy link
Copy Markdown
Owner

tdhock commented Sep 9, 2023

hi thanks for the PR! can you please clarify what build this would fix? I do not see the warning in that linked issue in any builds.

@barracuda156
Copy link
Copy Markdown
Contributor Author

@tdhock Relevant for older macOS; analogous to isnan issue here, for example: AcademySoftwareFoundation/openexr#1448

AFAIK, this should not have any adverse affects for other systems; of course, if any such concerns exist, the fix should be conditional.

@barracuda156
Copy link
Copy Markdown
Contributor Author

barracuda156 commented Sep 9, 2023

P. S. On macOS this is confirmed to build fine across every system from 10.6 through 13: https://ports.macports.org/port/R-binsegRcpp/details
PowerPC build confirmed locally (no buildbot for it at the moment).
We apply the fix unconditionally, so it works both with Clang and GCC: https://github.com/macports/macports-ports/blob/master/R/R-binsegRcpp/Portfile

@tdhock tdhock merged commit 15becb3 into tdhock:master Sep 10, 2023
@barracuda156 barracuda156 deleted the fix_isfinite branch September 10, 2023 07:31
@barracuda156
Copy link
Copy Markdown
Contributor Author

@tdhock Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error: 'isfinite' was not declared in this scope; did you mean 'std::isfinite'?

2 participants