fix(ubuntu-universe): fix two ARM64 bugs in ports repo state#221
Closed
jonathanlooi wants to merge 1 commit intoteamdfir:masterfrom
Closed
fix(ubuntu-universe): fix two ARM64 bugs in ports repo state#221jonathanlooi wants to merge 1 commit intoteamdfir:masterfrom
jonathanlooi wants to merge 1 commit intoteamdfir:masterfrom
Conversation
Contributor
|
This was addressed in another PR. Appreciate you opening this up though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
Bug 1 — hardcoded
Suites: nobleThe ubuntu-ports repository entry was hardcoded to
noble, meaning thestate only works on Ubuntu 24.04. On Ubuntu 22.04 (Jammy), universe packages
couldn't be resolved, causing multiple SIFT tools to fail to install.
Bug 2 — YAML rendering failure in
unlessclauseThe list form of
unlesswith a grep command containingURIs: http://...causes Salt's YAML renderer to misparse the colon-space as a mapping key,
producing a CRITICAL rendering error that skips the entire state:
[CRITICAL] Rendering SLS 'base:sift.repos.ubuntu-universe' failed: could not find
expected ':'
Fixes
Suites: noblewith thelsb_distrib_codenamegrain so the correct suitenames are used for any supported Ubuntu release
unlesslist into a scalar with a simplified grep pattern, avoidingthe YAML parsing conflict
Tested on