Skip to content

Conversation

@dev-rminds
Copy link
Collaborator

Changes description & testing suggestions

Developers checklist

  • Check that dusk tests are working locally on compatible branch
  • Mobile version of changes is developed - if its a webshop feature, mobile version for this feature is developed

QA checklist

  • Check regress in implementations custom css - changes are not breaking other implementations designes
  • Feature is tested in different screen sizes - desktop, mobile
  • WCAG requirements are met - new feature is accessible by keyboard, there are an alt texts
  • Translations are done

@RobinMeles
Copy link
Collaborator

RobinMeles commented Oct 22, 2025

some feedback points @dev-rminds (also discussed with Linda)
❌ can we remove the 'Vanaf' (price from) label? Since for prices it makes sense, but if a product is free or informative it does not:
image
❌ feedback from Linda: can the provider link to the actual provider?
Figma:
image
current product page (plain text):
image
❌ feedback from Linda: can the whole section be clickable to collapse, instead of just the icon?
image
like we have on the FAQ:
image
❌ feedback from Linda: There is a section missing, which is in the Figma design:
image
on the current product page this is not shown:
image
The title would be "Misschien vind je dit ook leuk?". It shows 3 random products (from any provider), just like we have on the homepage
✅ rest is all looking great 🚀

@RobinMeles RobinMeles assigned dev-rminds and unassigned RobinMeles Oct 22, 2025
@dev-rminds dev-rminds assigned RobinMeles and unassigned dev-rminds Oct 23, 2025
@dev-rminds dev-rminds force-pushed the product-layout-update branch from ba1e69b to 3a7fe72 Compare October 23, 2025 13:22
@dev-rminds dev-rminds assigned dev-rminds and unassigned RobinMeles Nov 3, 2025
@dev-rminds dev-rminds assigned RobinMeles and unassigned dev-rminds Nov 3, 2025
@RobinMeles RobinMeles merged commit 47db087 into develop Nov 4, 2025
4 checks passed
@RobinMeles RobinMeles deleted the product-layout-update branch November 4, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants