Skip to content

Comments

Allow PHP 8.4#159

Merged
localheinz merged 1 commit intoteapot-php:mainfrom
holtkamp:patch-1
Jan 5, 2025
Merged

Allow PHP 8.4#159
localheinz merged 1 commit intoteapot-php:mainfrom
holtkamp:patch-1

Conversation

@holtkamp
Copy link
Contributor

No description provided.

@theodorejb
Copy link

Why block future versions of PHP in the first place? This makes it difficult for users to test the library with upcoming PHP releases and find/fix issues. It would be better to simply set a minimum PHP version, i.e. "php": ">=7.4".

@localheinz localheinz self-assigned this Jan 5, 2025
@localheinz localheinz merged commit e557b9b into teapot-php:main Jan 5, 2025
2 checks passed
@localheinz
Copy link
Contributor

Thank you, @holtkamp and @theodorejb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants