fix(cd): require staging infra success before production deployment#377
Merged
rvanmaanen merged 3 commits intomainfrom May 1, 2026
Merged
fix(cd): require staging infra success before production deployment#377rvanmaanen merged 3 commits intomainfrom
rvanmaanen merged 3 commits intomainfrom
Conversation
Add deploy-staging-infra to the deploy-production job's needs array so production deployment won't proceed if staging infrastructure fails. Agent-Logs-Url: https://github.com/techhubms/techhub/sessions/946cdf93-0f88-4d45-b713-1c8edfa22724 Co-authored-by: rvanmaanen <4835258+rvanmaanen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix staging failure causing production deployment issues
fix(cd): require staging infra success before production deployment
May 1, 2026
The @description decorator for adminIpAddresses used a single-quoted string spanning two lines, which is invalid Bicep syntax. Single-quoted strings cannot contain newlines. This caused the parser to fail on every subsequent line, breaking both staging and production deployments. Agent-Logs-Url: https://github.com/techhubms/techhub/sessions/0d549980-361d-4da0-b86b-84623d884815 Co-authored-by: rvanmaanen <4835258+rvanmaanen@users.noreply.github.com>
Contributor
✅ PR Preview Environment RemovedThe preview environment for this pull request has been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploy-staging-infrato productionneedsso production won't deploy if staging failsaz bicep build