Merged
Conversation
Member
|
What parameter issues are you facing ? |
Contributor
Author
|
client id is not passed to check function and loadActionByCode function client and action are typecast. |
coolbung
reviewed
Jul 31, 2018
| * @since __DEPLOY_VERSION__ | ||
| */ | ||
| public static function loadActionByCode(String $code, String $client) | ||
| public static function loadActionByCode($code, $client) |
Member
There was a problem hiding this comment.
Why did you remove the typecasting ? Do you see any integer only values of code or client ?
coolbung
reviewed
Jul 31, 2018
| $result = $user->authorise($action, $client); | ||
|
|
||
| return $result && self::check($userId, $client, $action); | ||
| return $result && self::check($userId, $client, $action, $contentId); |
Contributor
Author
There was a problem hiding this comment.
@thite-amol - Please check this comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some function parameter issues