Skip to content

Task #143449 chore: support HTTP_X_IDENTIFIER in get request of users API #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manojLondhe merged 5 commits into from
Apr 19, 2019
Merged

Task #143449 chore: support HTTP_X_IDENTIFIER in get request of users API #14

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b1b3125
Merge pull request #10 from techjoomla/release-2.0.0
manojLondhe Apr 15, 2019
9cfa98d
Merge branch 'release-2.0.1' of https://github.com/techjoomla/plg_api…
Apr 18, 2019
cc87ef4
Task #143449 chore: support HTTP_IDENTIFIER in get request of user API
Apr 18, 2019
accb88e
Task #143449 chore: Update HTTP_IDENTIFER to HTTP_X_IDENTIFIER
Apr 18, 2019
c1c8b00
Task #143449 chore: support HTTP_IDENTIFIER in get request of users API
Apr 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/users/user.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public function post()
$params = JComponentHelper::getParams("com_users");
$response = new stdClass;

$xidentifier = $app->input->server->get('HTTP_IDENTIFIER');
$xidentifier = $app->input->server->get('HTTP_X_IDENTIFIER');
$fidentifier = $app->input->server->get('HTTP_FORCECREATE');

if ($formData['username'] == '' || $formData['name'] == '' || $formData['email'] == '')
Expand Down Expand Up @@ -156,14 +156,16 @@ public function get()
{
$input = JFactory::getApplication()->input;
$id = $input->get('id', 0, 'int');
$xidentifier = $input->server->get('HTTP_X_IDENTIFIER', '', 'String');

/*
* If we have an id try to fetch the user
* @TODO write user field mapping logic here
*/
if ($id)
{
$user = JUser::getInstance($id);
// Get a user object
$user = $this->retriveUser($xidentifier, $id);

if (! $user->id)
{
Expand Down Expand Up @@ -262,7 +264,7 @@ public function delete()
{
$app = JFactory::getApplication();
$userIdentifier = $app->input->get('id', 0, 'STRING');
$xidentifier = $app->input->server->get('HTTP_IDENTIFIER');
$xidentifier = $app->input->server->get('HTTP_X_IDENTIFIER', '', 'String');

$loggedUser = JFactory::getUser();

Expand Down