Task #179501 feat: Impersonate Login API#33
Merged
manojLondhe merged 8 commits intotechjoomla:release-2.1.0from Feb 14, 2022
Merged
Task #179501 feat: Impersonate Login API#33manojLondhe merged 8 commits intotechjoomla:release-2.1.0from
manojLondhe merged 8 commits intotechjoomla:release-2.1.0from
Conversation
added 5 commits
February 14, 2022 15:29
manojLondhe
reviewed
Feb 14, 2022
src/users/impersonatelogin.php
Outdated
| { | ||
| // Init variables | ||
| $obj = new stdclass; | ||
| $jinput = JFactory::getApplication()->input; |
Member
There was a problem hiding this comment.
JFactory => use non J prefix classses wherever available
manojLondhe
reviewed
Feb 14, 2022
|
|
||
| if ($userId == null) | ||
| { | ||
| $model = FD::model('Users'); |
Member
There was a problem hiding this comment.
FD is older library of Easysocial.
WIll this work without ES when email is passed?
Author
There was a problem hiding this comment.
No...I have added another function to fetch email
manojLondhe
reviewed
Feb 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.