CHI-2760 Build script for reindexing contacts and cases#652
Merged
mythilytm merged 8 commits intoCHI-2702-reindex-contactsfrom Jun 7, 2024
Merged
CHI-2760 Build script for reindexing contacts and cases#652mythilytm merged 8 commits intoCHI-2702-reindex-contactsfrom
mythilytm merged 8 commits intoCHI-2702-reindex-contactsfrom
Conversation
…CHI-2760-reindex-script
gpaoloni
approved these changes
Jun 6, 2024
Collaborator
gpaoloni
left a comment
There was a problem hiding this comment.
Looks good to me, thanks! Just a very small comment for better usability.
Comment on lines
115
to
117
| if (!response.ok) { | ||
| throw new Error(`Failed to submit request: ${response.statusText}`); | ||
| } |
Collaborator
There was a problem hiding this comment.
Let's change this throws for console.errors here and in cases, to avoid aborting the whole operation. Also it would be good to add more context: what failed, the cases or contact operation?
This was referenced Jun 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes a bash script for reindexing contacts and cases. This includes updates to the following files:
Checklist
Other Related Issues
None
Verification steps
hrm.ts. Check that sqs queue has triggered the reindexing successfullyAFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P