Skip to content

Comments

CHI-2760 Build script for reindexing contacts and cases#652

Merged
mythilytm merged 8 commits intoCHI-2702-reindex-contactsfrom
CHI-2760-reindex-script
Jun 7, 2024
Merged

CHI-2760 Build script for reindexing contacts and cases#652
mythilytm merged 8 commits intoCHI-2702-reindex-contactsfrom
CHI-2760-reindex-script

Conversation

@mythilytm
Copy link
Contributor

@mythilytm mythilytm commented Jun 3, 2024

Description

This PR includes a bash script for reindexing contacts and cases. This includes updates to the following files:

  • Added functionality to reindex contacts and cases based on specified dateFrom and dateTo. Added command options for reindexing contacts and cases based on date range.
  • Updated instructions and usage details for the reindex script.

Checklist

  • Corresponding issue has been opened
  • New tests added
  • Feature flags / configuration added

Other Related Issues

None

Verification steps

  • Start the devops instance and run the admin-cli on hrm.ts. Check that sqs queue has triggered the reindexing successfully

AFTER YOU MERGE

  1. Cut a release tag using the GitHub workflow. Wait for it to complete and notify in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

@mythilytm mythilytm changed the title feat: build script for reindexing contacts and cases CHI-2760 Build script for reindexing contacts and cases Jun 5, 2024
@mythilytm mythilytm marked this pull request as ready for review June 5, 2024 17:25
@mythilytm mythilytm requested a review from gpaoloni June 5, 2024 17:25
Copy link
Collaborator

@gpaoloni gpaoloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! Just a very small comment for better usability.

Comment on lines 115 to 117
if (!response.ok) {
throw new Error(`Failed to submit request: ${response.statusText}`);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change this throws for console.errors here and in cases, to avoid aborting the whole operation. Also it would be good to add more context: what failed, the cases or contact operation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants