Skip to content

Comments

Lex: Support to multiple languages#480

Merged
murilovmachado merged 27 commits intogian_CHI-175-lexfrom
murilo_lex_2
Jul 5, 2023
Merged

Lex: Support to multiple languages#480
murilovmachado merged 27 commits intogian_CHI-175-lexfrom
murilo_lex_2

Conversation

@murilovmachado
Copy link
Contributor

@murilovmachado murilovmachado commented Jun 26, 2023

Description

This PR adds support to multiple languages for Lex bots.

Checklist

  • Corresponding issue has been opened
  • New tests added

Related Issues

Fixes https://tech-matters.atlassian.net/browse/CHI-1792

Verification steps

The easiest way to test: hardcode language on Studio flow. Then, test both languages.
Available languages for Aselo Dev: en-US, es-CO.

@murilovmachado murilovmachado marked this pull request as draft June 26, 2023 18:08
Copy link
Collaborator

@gpaoloni gpaoloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!!

console.log('Channel unblocked and bot session deleted');
}

// Why we need to send this message?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The always want to send the Lex response to the channel, so the user can see it. The reason it is moved after all the other code is that nextAction now adds a webhook with a Studio trigger for pre survey, and the message being sent after will trigger the "second execution" of the flow so the channel triggers a task for Flex and all of that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I've forgotten to remove this comment😅

I've noticed it later on. I just got confused initially when I was getting code from the Lex pivot stuff.
I'll remove the comment

@murilovmachado murilovmachado merged commit 82c539c into gian_CHI-175-lex Jul 5, 2023
@murilovmachado murilovmachado deleted the murilo_lex_2 branch July 5, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants