Skip to content

chore: Update deployment scripts#228

Merged
techniq merged 1 commit intotechniq:mainfrom
shyakadavis:patch-1
Aug 4, 2024
Merged

chore: Update deployment scripts#228
techniq merged 1 commit intotechniq:mainfrom
shyakadavis:patch-1

Conversation

@shyakadavis
Copy link
Contributor

@shyakadavis shyakadavis commented Aug 4, 2024

Saw you were still using node 18.x, and left it as such, but could update if needed.

TODO:

  • Disable Cloudflare's GitHub integration on the repo
  • Add variable secrets to this repo (CF_ACCOUNT_ID & CF_API_TOKEN)
  • Confirm that the project name is layerchart on Cloudflare

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2024

⚠️ No Changeset found

Latest commit: b623a00

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
layerchart ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2024 6:33am

@shyakadavis
Copy link
Contributor Author

Huh, still seeing Vercel trying to deploy. Was I wrong in assuming that you're using CF now, Sean?

@techniq
Copy link
Owner

techniq commented Aug 4, 2024

Thanks @shyakadavis ❤️. I re-enabled Vercel after I learned that CF didn't provide PR previews, and utilize the adapter-auto ATM to deploy to both (CF is the primary and where layerchart.com is hosted). Since I had stopped paying for a Vercel Pro account, this means the PR previews are really only for me, which isn't optimal but still useful for me to review PRs.

So in short, yes I am still using Vercel mostly as a stop gap solution for PR previews, but likely turning it off after this. It's been helpful once or twice to troubleshoot a CF-specific failing build, but likely will disable it to cut down on the PR comment noise.

Thanks so much for the PR. I plan to finish the setup this afternoon when I get back home.

Copy link
Owner

@techniq techniq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shyakadavis!

@techniq techniq merged commit 3ac252b into techniq:main Aug 4, 2024
@techniq
Copy link
Owner

techniq commented Aug 5, 2024

@shyakadavis LayerChart and Svelte UX deployments are all migrated over 🎉

I switched from adapter-auto to adapter-cloudflare as I didn't see a straightforward way to support adapter-auto since the build is happening in Github Actions instead of Cloudflare infra. I also removed the Vercel integration since it would need setup similarly without using adapter-auto, and not worth it now 😁 (PR previews for everyone!)

Thanks again!

@shyakadavis shyakadavis deleted the patch-1 branch August 5, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants