Use "id" of elements for anchors instead of auto-generating a tag #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the accuracy of anchor locations in large documents like the nixpkgs manual, where on occasion the autoanchor counter gets out of sync. It also seems like the right thing to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had issues with generating dashing docsets in the nixpkgs manual (a huge single html page) where the autoanchors generated by dashing got out of sync with where Dash expects to jump. Since that manual uses
idattributes for anchors, I figured this is the easiest way to get accurate anchor expressions, and it works.This might also address #57, if the matched node has an
idattribute.