Conversation
…artucalgary/Networking-Icebreakers into feature/STR-56-DataModels
rxmox
reviewed
Nov 27, 2025
| // router is like a mini-express app that allows grouping of related routes together | ||
| import { Router } from 'express'; | ||
| import { getUsers, createUser } from '../controllers/user_controller'; | ||
| import { getUsers, createUser } from '../controllers/user_controller.ts'; |
Collaborator
There was a problem hiding this comment.
doesn't matter much, but it is better to omit .ts
rxmox
reviewed
Nov 27, 2025
| import { Router } from 'express'; | ||
| import { getUsers, createUser } from '../controllers/user_controller'; | ||
| import { getUsers, createUser } from '../controllers/user_controller.ts'; | ||
| // Importing controller functions that handle logic for each route |
Collaborator
There was a problem hiding this comment.
the only diff in this file is verbose comments, it is recommended to keep comments minimal
rxmox
reviewed
Nov 27, 2025
| passwordChangedAt?: Date; | ||
| createdAt?: Date; | ||
| updatedAt?: Date; | ||
| password: string; |
Collaborator
There was a problem hiding this comment.
it is standard practice to store passwordHash instead of password, I think naming wise passwordHash is more descriptive
rxmox
reviewed
Nov 27, 2025
| name: string; | ||
| email: string; | ||
| passwordHash: string; | ||
| lastLogin?: Date; |
Collaborator
There was a problem hiding this comment.
not sure why the rest of the fields are removed here, they have been used and tested. For example passwordChangedAt is useful to invalidate existing JWTs/sessions after a password change
Collaborator
|
The reason failing of CI Build because of the change of user model |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created Event and Participant Data model. Created routes and controllers for creating events, and getting event information. Commit History Is kind of messed up because My git crashed and bricked itself mid rebase while also committing, I cant even tell you how it happened. The only changes should be the creating event and participant models, event controller and routes. As well as adding said routes to the app.ts.