Fix security gate tripping on unit test file containing fake secrets#47
Draft
Fix security gate tripping on unit test file containing fake secrets#47
Conversation
…cret scanning Agent-Logs-Url: https://github.com/techwavedev/openminions/sessions/83a05781-6a20-43f8-b72b-3c1b70622312 Co-authored-by: techwavedev <36747067+techwavedev@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix security gate trips on test_unit_security_gate.py
Fix security gate tripping on unit test file containing fake secrets
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI security gate was failing because
tests/test_unit_security_gate.pycontains intentional fake API keys to verify pattern detection — and those keys matched the scanner's own regexes.Changes
SCAN_EXCLUSIONSwas never applied — the set was defined but the scan loop inmain()never checked it; added the skip guard:SCAN_EXCLUSIONSalongside the existing entries (bin/security_gate.py,SECURITY.md) — these files contain patterns/examples, not real secrets.