Allow rows that are null to be valid existing values#1240
Merged
dhensby merged 2 commits intotediousjs:masterfrom Nov 22, 2021
Merged
Allow rows that are null to be valid existing values#1240dhensby merged 2 commits intotediousjs:masterfrom
dhensby merged 2 commits intotediousjs:masterfrom
Conversation
3f5d6b2 to
5659195
Compare
Collaborator
Author
|
I'm a little cautious about introducing this into the v7 branch given it's a fairly significant (though intuitive) behaviour change. I'm also worried that it may introduce some regressions in other queries that you wouldn't expect it in. |
5659195 to
78ac52a
Compare
78ac52a to
e397a61
Compare
Contributor
|
Just chiming in that |
This was referenced Jan 30, 2022
1 task
This was referenced Jan 30, 2022
This was referenced Jan 31, 2022
1 task
This was referenced Jan 31, 2022
This was referenced Jan 10, 2023
This was referenced Mar 21, 2023
This was referenced Sep 6, 2023
1 task
1 task
1 task
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does:
fixes #1161
todo - decide if this is a breaking change.
Possibly this means there's no need for
arrayRowMode?!