Skip to content

Move libzip out of the public header#46

Merged
mattcieslak merged 3 commits intomainfrom
clean-up-trx-h
Mar 20, 2026
Merged

Move libzip out of the public header#46
mattcieslak merged 3 commits intomainfrom
clean-up-trx-h

Conversation

@mattcieslak
Copy link
Copy Markdown
Collaborator

This is an attempt to make it easier to install libtrx as a shared library. It removes libzip references from the public header so that trx-cpp doesn't have to also export libzip

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 73.91304% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.64%. Comparing base (f693e7b) to head (23074d1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/trx.cpp 58.33% 20 Missing ⚠️
include/trx/trx.tpp 69.23% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   88.63%   88.64%           
=======================================
  Files          15       15           
  Lines        7736     7749   +13     
  Branches     1042     1043    +1     
=======================================
+ Hits         6857     6869   +12     
- Misses        879      880    +1     
Flag Coverage Δ
linux 87.83% <75.00%> (+<0.01%) ⬆️
macos 88.47% <74.72%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mattcieslak mattcieslak merged commit 21b963c into main Mar 20, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant