[ENH] Dev-ops, N+1 offset, temporary directory#5
[ENH] Dev-ops, N+1 offset, temporary directory#5anibalsolon wants to merge 17 commits intomasterfrom
Conversation
frheault
left a comment
There was a problem hiding this comment.
I think the changes look great!
The next item on the list is about .
Maybe after that item, I can try to run the test on my new computer and see if it works?
|
On my mac, I am currently seeing: |
|
@frheault good that it is working now- yes, this command is included in the README The gtest should have been installed via conan, not sure why it didnt find |
|
@anibalsolon Was I doing something wrong or was the file in ./examples/load_trx.cpp not build? |
|
@anibalsolon Is there something I can run or test before of meeting this afternoon? |
|
@frheault not really- we may need to discuss some design decisions about the cpp implementation today |
|
I think most of these issues are addressed now. We can open new issues if you'd like to revisit |


This PR:
datadir