Skip to content

Conversation

@spetrosi
Copy link
Contributor

@spetrosi spetrosi commented Aug 5, 2024

prepare:, how: feature, epel: enabled fails on EL 10.
prepare's feature does not provide a way to avoid running on a specific platform.
Hence, my prepare passes on all platforms but fails on EL 10 because EL 10 doesn't have epel-release available:

fatal: [root@10.0.187.147]: FAILED! => {"changed": false, "failures":
["No package epel-release available."], "msg": "Failed to install some
of the specified packages", "rc": 1, "results": []}

For now, avoid enabling epel on EL 10.

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@spetrosi
Copy link
Contributor Author

spetrosi commented Aug 5, 2024

On other platforms, I enable epel to install beakerlib. On EL 10, beakerlib is installed by default from beaker-harness.

@happz
Copy link
Contributor

happz commented Aug 5, 2024

On other platforms, I enable epel to install beakerlib. On EL 10, beakerlib is installed by default from beaker-harness.

That is true, but that applies only to RH-internal testing, correct? Nobody outside of RH will have access to any beaker-harness repo. BTW, wouldn't beaker-harness provide beakerlib package for RHEL9 and RHEL8 as well?

@spetrosi
Copy link
Contributor Author

spetrosi commented Aug 5, 2024

I would dare to say that there will be EPEL10, its nonexistence is just temporary

This is a valid concerns, and it means that if we apply this patch we need to remove it after epel i available on EL 10.

BTW, wouldn't beaker-harness provide beakerlib package for RHEL9 and RHEL8 as well?

It does provide the package, but it doesn't install it, and doesn't do the logic to enable epel, but I can workardound this.

That said, I've applied such a preparation task in my plan instead of using feature: epel` and it works fine. I agree to close this PR.

  - name: Enable epel to install beakerlib
    script: |
      # CS 10 and Fedora doesn't require epel
      if grep -q -e 'CentOS Stream release 10' -e 'Fedora release' /etc/redhat-release; then
        exit 0
      fi
      yum install epel-release yum-utils -y
      yum-config-manager --enable epel epel-debuginfo epel-source 

@happz
Copy link
Contributor

happz commented Aug 5, 2024

I would dare to say that there will be EPEL10, its nonexistence is just temporary

This is a valid concerns, and it means that if we apply this patch we need to remove it after epel i available on EL 10.

Yes, that would indeed happen. And I wouldn't be afraid of it, EPEL is simply not yet available for RHEL-10, no point in installing it now, but one day, we will need to support it, so, not much we can do about such a switcheroo :)

@spetrosi spetrosi closed this Aug 5, 2024
@happz
Copy link
Contributor

happz commented Aug 5, 2024

@spetrosi why closing this PR? :O The idea was correct, AFAICT, EPEL 10 is not available, therefore tmt should not attempt to install it. The revert will be needed in the future, but that's how things are, and it's a big deal.

@spetrosi
Copy link
Contributor Author

spetrosi commented Aug 5, 2024

Okay, I've added comments inline as you suggested.

@spetrosi spetrosi requested a review from happz August 6, 2024 13:33
@spetrosi
Copy link
Contributor Author

spetrosi commented Aug 8, 2024

@happz is it ready to be merged?

@happz
Copy link
Contributor

happz commented Aug 9, 2024

@happz is it ready to be merged?

I don't think so, it needs more reviewers :) And ready or not, it needs some labels and a milestone.

@happz happz added the step | prepare Stuff related to the prepare step label Aug 9, 2024
@happz happz added this to the 1.36 milestone Aug 9, 2024
@happz happz added ready for merge ci | full test Pull request is ready for the full test execution labels Aug 20, 2024
prepare:, how: feature, epel: enabled fails on EL 10.
prepare's `feature` does not provide a way to avoid running on a
specific platform. Hence, my `prepare` passes on all platforms but fails
on EL 10 because EL 10 doesn't have epel-release available:

fatal: [root@10.0.187.147]: FAILED! => {"changed": false, "failures":
["No package epel-release available."], "msg": "Failed to install some
of the specified packages", "rc": 1, "results": []}

For now, avoid enable epel on EL 10.
richm added a commit to linux-system-roles/snapshot that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/systemd that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/postgresql that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/podman that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/postfix that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/selinux that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/pam_pwd that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/nbde_server that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/network that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/mssql that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/nbde_client that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/metrics that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/keylime_server that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/journald that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/logging that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/hpc that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/gfs2 that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/ha_cluster that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/crypto_policies that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/fapolicyd that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/firewall that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/aide that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/ad_integration that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/bootloader that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/certificate that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/cockpit that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/kdump that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/kernel_settings that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/ssh that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
richm added a commit to linux-system-roles/.github that referenced this pull request Sep 9, 2025
Now that teemtee/tmt#3128 has merged
we can use the new epel feature to enable EPEL for testing farm

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci | full test Pull request is ready for the full test execution step | prepare Stuff related to the prepare step

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants