fix: Avoid recursive error on nested group references#1016
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1016 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 117 117
Lines 9203 9256 +53
Branches 2176 2189 +13
=========================================
+ Hits 9203 9256 +53 ☔ View full report in Codecov by Sentry. |
Owner
Author
|
Honestly, one of these days, I am going to remove the support for nested classes.... it's such a pain sometimes. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




📒 Description
The generator supports inner class references, only from outer -> inner, not for inner classes on the same level, or any kind of uneven references, like this.
This is a limiting factor for groups with self references, that causes recursion limit errors. Let's see if we can address that!
Resolves #1008
🔗 What I've Done
💬 Comments
🛫 Checklist