Use the required metadata flag only for attributes#1208
Merged
Conversation
a9a2f8e to
4bd2e20
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1208 +/- ##
===========================================
+ Coverage 99.97% 100.00% +0.02%
===========================================
Files 116 116
Lines 9364 9376 +12
Branches 1433 1439 +6
===========================================
+ Hits 9362 9376 +14
+ Misses 1 0 -1
+ Partials 1 0 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4bd2e20 to
985dfa7
Compare
985dfa7 to
8864597
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



📒 Description
Since we dropped 3.9, we can finally safely rely on the typing annotation to figure out if a simple element, value are required or not. We only need this metadata for attributes with default values in order to describe if they must always appear in the xml output or not.
🔗 What I've Done
💬 Comments
🛫 Checklist