Skip to content

Use the required metadata flag only for attributes#1208

Merged
tefra merged 4 commits intomainfrom
rework-optionals
Feb 8, 2026
Merged

Use the required metadata flag only for attributes#1208
tefra merged 4 commits intomainfrom
rework-optionals

Conversation

@tefra
Copy link
Owner

@tefra tefra commented Feb 8, 2026

📒 Description

Since we dropped 3.9, we can finally safely rely on the typing annotation to figure out if a simple element, value are required or not. We only need this metadata for attributes with default values in order to describe if they must always appear in the xml output or not.

🔗 What I've Done

Write a description of the steps taken to resolve the issue

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (dca262b) to head (8864597).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #1208      +/-   ##
===========================================
+ Coverage   99.97%   100.00%   +0.02%     
===========================================
  Files         116       116              
  Lines        9364      9376      +12     
  Branches     1433      1439       +6     
===========================================
+ Hits         9362      9376      +14     
+ Misses          1         0       -1     
+ Partials        1         0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2026

@tefra tefra merged commit f3bbc43 into main Feb 8, 2026
14 checks passed
@tefra tefra deleted the rework-optionals branch February 8, 2026 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments