Fix PycodeSerializer to escape unicode characters in string values#877
Merged
tefra merged 1 commit intotefra:mainfrom Dec 8, 2023
Merged
Fix PycodeSerializer to escape unicode characters in string values#877tefra merged 1 commit intotefra:mainfrom
tefra merged 1 commit intotefra:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #877 +/- ##
=======================================
Coverage 99.89% 99.89%
=======================================
Files 105 105
Lines 9302 9302
Branches 2078 2078
=======================================
Hits 9292 9292
Misses 3 3
Partials 7 7 ☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📒 Description
Ensure that unicode characters in
PycodeSerializerare correctly escaped and form valid Python code.Resolves #876
🔗 What I've Done
Escapes any unicode characters in strings while still being represented as ASCII data. Also implements a unit test to exhibit desired behavior.
💬 Comments
None
🛫 Checklist