Generate valid variable names when using originalCase naming convention#881
Merged
tefra merged 1 commit intotefra:mainfrom Dec 16, 2023
Merged
Generate valid variable names when using originalCase naming convention#881tefra merged 1 commit intotefra:mainfrom
tefra merged 1 commit intotefra:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #881 +/- ##
==========================================
- Coverage 99.89% 99.89% -0.01%
==========================================
Files 105 105
Lines 9308 9307 -1
Branches 2080 2079 -1
==========================================
- Hits 9298 9297 -1
Misses 3 3
Partials 7 7 ☔ View full report in Codecov by Sentry. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

📒 Description
When using
originalCasenaming syntax for classes or fields where the names have been generated by the library, ensure that only valid characters are used for the variable in the generated Python code.Resolves #880
🔗 What I've Done
Implements a new method in the
utils.textlibrary namedvariable(), which will use some simple regex matching to strip out anything except alphanumeric characters and underscores from the variable name. It will also ensure that a variable name does not start with a digit character.This resolves both of the examples listed in #880.
💬 Comments
None
🛫 Checklist