fix: Always keep forward references for choice types#886
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #886 +/- ##
=======================================
Coverage 99.89% 99.89%
=======================================
Files 105 105
Lines 9311 9311
Branches 2080 2080
=======================================
Hits 9301 9301
Misses 3 3
Partials 7 7 ☔ View full report in Codecov by Sentry. |
This was referenced Dec 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📒 Description
Ensures that compound fields in dataclasses maintain forward references, even if postponed annotations are enabled.
Resolves #882
🔗 What I've Done
Add the choice exception to the postpone annotations rule
💬 Comments
🛫 Checklist