Setup logging according to the logging cookbook#68
Open
HaasCM wants to merge 1 commit intotehruttiger:masterfrom
Open
Setup logging according to the logging cookbook#68HaasCM wants to merge 1 commit intotehruttiger:masterfrom
HaasCM wants to merge 1 commit intotehruttiger:masterfrom
Conversation
Python has the logging cookbook (please see https://docs.python.org/3/library/logging.html for more info). It basically allows you tos setup the logger to log to both a file and the console, while using two different formatters. So converted the logging functionality to using the python logging module with two seperate handlers, one for console and one for file. This also allowed us to clean up the print statements that duplicated the log messages as the handlers would handle console and file output. Also setup the formatters to capture the time of the log message so we don't need to record the time in the log messasge anymore.
Owner
|
@HaasCM I've invited you to collaborate. Hoping you're interested as I don't actively update Stockpiler anymore. |
Collaborator
Author
|
Sure! Just accepted the invite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python has the logging cookbook (please see
https://docs.python.org/3/library/logging.html for more info). It basically allows you tos setup the logger to log to both a file and the console, while using two different formatters.
So converted the logging functionality to using the python logging module with two seperate handlers, one for console and one for file.
This also allowed us to clean up the print statements that duplicated the log messages as the handlers would handle console and file output.
Also setup the formatters to capture the time of the log message so we don't need to record the time in the log messasge anymore.