Skip to content

Add ghcr.io migration banner to README.md#1327

Merged
tekton-robot merged 1 commit into
tektoncd:mainfrom
twoGiants:issue-645-website-registry-migration-banner
Apr 11, 2025
Merged

Add ghcr.io migration banner to README.md#1327
tekton-robot merged 1 commit into
tektoncd:mainfrom
twoGiants:issue-645-website-registry-migration-banner

Conversation

@twoGiants
Copy link
Copy Markdown
Member

@twoGiants twoGiants commented Apr 10, 2025

Changes

Add ghcr.io migration banner to README.md. Add types to code blocks in and update links and references in manifests to use ghcr.

Issue tektoncd/website#645.

/kind documentation

Screenshot

Screenshot from 2025-04-10 12-33-32
Screenshot from 2025-04-10 12-35-38

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Follows the authoring recommendations
  • Includes docs (if user facing)
  • Includes tests (for new tasks or changed functionality)
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Commit messages follow commit message best practices
  • Has a kind label. You can add one by adding a comment on this PR that
    contains /kind <type>. Valid types are bug, cleanup, design, documentation,
    feature, flake, misc, question, tep
  • Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
    • File path follows <kind>/<name>/<version>/name.yaml

    • Has README.md at <kind>/<name>/<version>/README.md

    • Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

    • Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

    • mandatory spec.description follows the convention

        ```
      
        spec:
          description: >-
            one line summary of the resource
      
            Paragraph(s) to describe the resource.
        ```
      

See the contribution guide for more details.

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 10, 2025
@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 10, 2025
@tekton-robot
Copy link
Copy Markdown

Hi @twoGiants. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 10, 2025
@twoGiants twoGiants force-pushed the issue-645-website-registry-migration-banner branch from 5de2892 to 65085d6 Compare April 10, 2025 10:39
Add types to codeblocks in README and update links and references in
manifests to use ghcr.

Issue tektoncd/website#654.

Signed-off-by: Stanislav Jakuschevskij <stas@two-giants.com>
@twoGiants twoGiants force-pushed the issue-645-website-registry-migration-banner branch from 65085d6 to 49a4564 Compare April 10, 2025 13:16
Copy link
Copy Markdown
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 11, 2025
@tekton-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2025
@tekton-robot tekton-robot merged commit 6f6d869 into tektoncd:main Apr 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants