Skip to content

EventListener Log Tests Failing Due to Changed Output #1248

@danielhelfand

Description

@danielhelfand

EventListener log tests are failing with the following errors:

    TestEventListenerE2E/Get_logs_of_EventListener_with_multiple_pods: eventListener_test.go:78: assertion failed: 
        Actual output: 
        [github-listener-interceptor-el-github-listener-interceptor-78b46d664d-2fdqb]: E1111 03:41:11.566102       1 reflector.go:178] k8s.io/client-go@v11.0.1-0.20190805182717-6502b5e7b1b5+incompatible/tools/cache/reflector.go:125: Failed to list *v1alpha1.EventListener: eventlisteners.triggers.tekton.dev is forbidden: User "system:serviceaccount:testcli-4qqwg:tekton-triggers-github-sa" cannot list resource "eventlisteners" in API group "triggers.tekton.dev" in the namespace "testcli-4qqwg"
        
        [github-listener-interceptor-el-github-listener-interceptor-78b46d664d-p8zjk]: E1111 03:41:13.946402       1 reflector.go:178] k8s.io/client-go@v11.0.1-0.20190805182717-6502b5e7b1b5+incompatible/tools/cache/reflector.go:125: Failed to list *v1alpha1.TriggerTemplate: triggertemplates.triggers.tekton.dev is forbidden: User "system:serviceaccount:testcli-4qqwg:tekton-triggers-github-sa" cannot list resource "triggertemplates" in API group "triggers.tekton.dev" in the namespace "testcli-4qqwg"
        
        [github-listener-interceptor-el-github-listener-interceptor-78b46d664d-z77zt]: E1111 03:41:11.004704       1 reflector.go:178] k8s.io/client-go@v11.0.1-0.20190805182717-6502b5e7b1b5+incompatible/tools/cache/reflector.go:125: Failed to list *v1alpha1.TriggerTemplate: triggertemplates.triggers.tekton.dev is forbidden: User "system:serviceaccount:testcli-4qqwg:tekton-triggers-github-sa" cannot list resource "triggertemplates" in API group "triggers.tekton.dev" in the namespace "testcli-4qqwg"
        
        Missing strings: Listen and serve on port 8080

While it's unclear what the change has been that has caused these tests to no longer pass, it is clear that these tests are fragile as they rely on log output, which can change as updates to Triggers occur. This is similar to what occurred in #1206.

Perhaps it would make sense to check the beginning of the log output from tkn as opposed to the output from the logs themselves.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/testingIssues or PRs related to testing

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions