Copy Over PipelineRun and TaskRun Spec for --last and use run Options#1134
Copy Over PipelineRun and TaskRun Spec for --last and use run Options#1134tekton-robot merged 1 commit intotektoncd:masterfrom danielhelfand:1133
Conversation
|
The following is the coverage report on the affected files.
|
|
/retest |
|
Failures seem related to set up of environment: |
|
/retest |
|
/test pull-tekton-cli-go-coverage |
|
The following is the coverage report on the affected files.
|
|
/retest |
|
The following is the coverage report on the affected files.
|
vdemeester
left a comment
There was a problem hiding this comment.
/meow
/cc @piyush-garg @pradeepitm12
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pradeepitm12, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |

Closes #1133
Changes
In order to avoid the issue of needing to add properties for
--lastand--use-taskrun/--use-pipelinerunoptions, the entire Spec of the previous TaskRun or PipelineRun should be copied over to the new run object. This will prevent future issues like #1133 and #862.This may also address #1119, but will not close the issue until there is further verification.
Submitter Checklist
make checkmake generatedRelease Notes