Skip to content

Copy Over PipelineRun and TaskRun Spec for --last and use run Options#1134

Merged
tekton-robot merged 1 commit intotektoncd:masterfrom
danielhelfand:1133
Aug 24, 2020
Merged

Copy Over PipelineRun and TaskRun Spec for --last and use run Options#1134
tekton-robot merged 1 commit intotektoncd:masterfrom
danielhelfand:1133

Conversation

@danielhelfand
Copy link
Copy Markdown
Member

@danielhelfand danielhelfand commented Aug 19, 2020

Closes #1133

Changes

In order to avoid the issue of needing to add properties for --last and --use-taskrun/--use-pipelinerun options, the entire Spec of the previous TaskRun or PipelineRun should be copied over to the new run object. This will prevent future issues like #1133 and #862.

This may also address #1119, but will not close the issue until there is further verification.

Submitter Checklist

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

Release Notes

Fix --last and --use-taskrun/--use-pipelinerun commands so that all properties are used as part of new run

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 19, 2020
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 19, 2020
@tekton-robot
Copy link
Copy Markdown
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/clustertask/start.go 80.3% 80.0% -0.3
pkg/cmd/pipeline/start.go 67.6% 67.2% -0.4
pkg/cmd/task/start.go 82.2% 81.9% -0.3

@danielhelfand
Copy link
Copy Markdown
Member Author

/retest

@danielhelfand
Copy link
Copy Markdown
Member Author

danielhelfand commented Aug 19, 2020

Failures seem related to set up of environment:

2020/08/19 15:55:24 main.go:319: Something went wrong: failed to prepare test environment: 
--provider=gke boskos failed to acquire project: resources not found

@danielhelfand
Copy link
Copy Markdown
Member Author

/retest

@danielhelfand
Copy link
Copy Markdown
Member Author

/test pull-tekton-cli-go-coverage

@tekton-robot
Copy link
Copy Markdown
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/clustertask/start.go 80.3% 80.0% -0.3
pkg/cmd/pipeline/start.go 67.6% 67.2% -0.4
pkg/cmd/task/start.go 82.2% 81.9% -0.3

@danielhelfand
Copy link
Copy Markdown
Member Author

/retest

@tekton-robot
Copy link
Copy Markdown
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/clustertask/start.go 80.3% 80.0% -0.3
pkg/cmd/pipeline/start.go 67.6% 67.2% -0.4
pkg/cmd/task/start.go 82.2% 81.9% -0.3

@danielhelfand danielhelfand changed the title WIP: Copy Over PipelineRun and TaskRun Spec for --last and use run Options Copy Over PipelineRun and TaskRun Spec for --last and use run Options Aug 19, 2020
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2020
Copy link
Copy Markdown
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tekton-robot
Copy link
Copy Markdown
Contributor

@vdemeester: cat image

Details

In response to this:

/meow
/cc @piyush-garg @pradeepitm12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2020
Copy link
Copy Markdown
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2020
@tekton-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pradeepitm12, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [pradeepitm12,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tkn ct start <cluster-task-name> -L does not use the --timeout value of previous run

4 participants