WIP: Attempt at adding a plugin sub-cmd#1136
Conversation
Fixes: tektoncd#1039 Signed-off-by: Sunil Thaha <sthaha@redhat.com>
tekton-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
the
size/M
|
|
||
| errX := syscall.Exec(exCmd, append([]string{exCmd}, os.Args[2:]...), os.Environ()) | ||
| log.Printf("Command finished with error: %v", errX) | ||
|
|
There was a problem hiding this comment.
We should exit with the sub process exit code shouldn't we ?
|
Closing in favor of #1178 |
|
@vdemeester: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3 participants
Changes
This is only a POC that adds a plugin extension model like kubectl (tested only on linux)
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes