Integrate Hub commands into tkn by sthaha · Pull Request #1203 · tektoncd/cli

sthaha · 2020-10-14T09:53:06Z

Changes

This PR integrates hub commands into the Tekton CLI. Until we decide on the nitty-gritty of the plugin implementation and its surrounding ecosystem (esp. shipping core plugins), this approach would allow us to provide the same UX tkn hub <commands> with very little change to the tkn cli.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Run the code checkers with make check
Regenerate the manpages, docs and go formatting with make generated
Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

sthaha · 2020-10-19T12:53:36Z

/test pull-tekton-cli-integration-tests-0_10

sthaha · 2020-10-19T13:17:25Z

/retest

sthaha · 2020-10-20T11:45:48Z

/test pull-tekton-cli-integration-tests

danielhelfand

Only thing I can think to add would be a simple test in https://github.com/tektoncd/cli/blob/2d3875def20311c3b762f487cfe046a6448e685f/test/e2e-tests.sh to execute the hub root command and also have a must_fail for tkn hub search since no hub is installed currently in our set up.

piyush-garg · 2020-10-21T14:27:53Z

Can we add Hub also to the readme section https://github.com/tektoncd/cli#useful-commands

This PR integrates hub commands into the Tekton CLI by making minimal changes to tkn. This is achieved by vendoring hub commands and adding those into the tkn root command. This approach allows us to provide the same UX `tkn hub <commands> ` with very little change to the tkn cli. Signed-off-by: Sunil Thaha <sthaha@redhat.com>

tekton-robot · 2020-10-22T03:13:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [piyush-garg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

danielhelfand

/lgtm

danielhelfand · 2020-10-22T03:24:36Z

@@ -0,0 +1,46 @@
+## tkn hub get pipeline
+
+Get pipeline by name, catalog and version


Nit: This should be Pipeline (see #605).

danielhelfand · 2020-10-22T03:25:09Z

@@ -0,0 +1,46 @@
+## tkn hub get task
+
+Get task by name, catalog and version


Nit: This should be Task (see #605)

#1215 | [Piyush Garg] Update readme for 0.13.1 and fix lint task | 2020/10/21-14:41 #1210 | [Daniel Helfand] common way of referring to tekton resources in user facing messages: ClusterTriggerBinding | 2020/10/21-15:55 #1209 | [Daniel Helfand] common way of referring to tekton resources in user facing messages: Condition | 2020/10/21-17:41 #1213 | [Daniel Helfand] common way of referring to tekton resources in user facing messages: TriggerTemplate | 2020/10/21-19:33 #1214 | [shuheiktgw] Fix unit test failures with go 1.15 | 2020/10/22-04:19 #1203 | [Sunil Thaha] Integrate Hub commands into tkn | 2020/10/22-04:41 #1217 | [Daniel Helfand] fix alignment of usage | 2020/10/22-18:47 #1218 | [Daniel Helfand] document NO_COLOR and edit README headers | 2020/10/26-15:40 #1224 | [Daniel Helfand] change --nocolour to --no-color | 2020/10/28-02:57 #1221 | [SM43] Updates Hub Dependency | 2020/10/28-04:51 null | [Daniel Helfand] deprecate -c shorthand for tkn version --check | 2020/11/03-15:37 null | [Pradeep Kumar] Bump pipeline and triggers deps | 2020/11/04-20:12 null | [Daniel Helfand] do not delete clustertask taskruns with --task flag | 2020/11/04-20:59 null | [Piyush Garg] Fix APIversion not shown on describe commands | 2020/11/05-10:54 null | [Pratik Jagrut] Add --all-namespaces flag to tkn triggerbinding list command | 2020/11/06-12:25 null | [Pratik Jagrut] Add --all-namespaces flag to tkn eventlistener list command | 2020/11/06-16:04 null | [vinamra28] Add --all-namespaces flag to TriggerTemplate List subcommand | 2020/11/06-19:39 null | [Chmouel Boudjnah] Make sure we target LTS for ubuntus | 2020/11/06-21:12 null | [Pratik Jagrut] Add --all-namespaces flag to tkn condition list command | 2020/11/09-14:14 null | [Daniel Helfand] remove EventListener log output assertion from e2e tests | 2020/11/11-16:52 null | [Pradeep Kumar] bump pipleine dependency to v0.18.0 | 2020/11/12-11:28 null | [dullest] fix function name typo | 2020/11/12-15:17 null | [Vincent Demeester] Makefile: remove darwin/386 from cross target 🌮 | 2020/11/13-15:58 null | [Pratik Jagrut] Add --no-headers flag to tkn clustertask list command | 2020/11/16-09:50 null | [Pratik Jagrut] Add --no-headers flag to tkn clustertriggerbinding list command | 2020/11/16-10:24 Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>

tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 14, 2020

tekton-robot requested review from piyush-garg and pradeepitm12 October 14, 2020 09:53

tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 14, 2020

sthaha force-pushed the tkn-hub-integration branch 2 times, most recently from 53886de to eaef7ef Compare October 19, 2020 06:32

sthaha force-pushed the tkn-hub-integration branch from eaef7ef to 4af52f1 Compare October 20, 2020 07:46

sthaha changed the title ~~[WIP] Integrate Hub commands into tkn~~ Integrate Hub commands into tkn Oct 20, 2020

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2020

danielhelfand reviewed Oct 20, 2020

View reviewed changes

Comment thread docs/cmd/tkn_hub_search.md Outdated

sthaha force-pushed the tkn-hub-integration branch 4 times, most recently from 4c92eff to 799f9e9 Compare October 21, 2020 09:12

sthaha requested a review from danielhelfand October 21, 2020 12:10

piyush-garg reviewed Oct 21, 2020

View reviewed changes

Comment thread test/e2e-tests.sh Outdated

sthaha force-pushed the tkn-hub-integration branch from 799f9e9 to cf284ed Compare October 21, 2020 23:38

piyush-garg approved these changes Oct 22, 2020

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2020

danielhelfand reviewed Oct 22, 2020

View reviewed changes

tekton-robot assigned danielhelfand Oct 22, 2020

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2020

tekton-robot merged commit d8805a3 into tektoncd:master Oct 22, 2020

danielhelfand mentioned this pull request Nov 10, 2020

Explore Adding oci Capabilities into tkn #1247

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate Hub commands into tkn#1203

Integrate Hub commands into tkn#1203
tekton-robot merged 1 commit intotektoncd:masterfrom
sthaha:tkn-hub-integration

sthaha commented Oct 14, 2020 •

edited

Loading

Uh oh!

sthaha commented Oct 19, 2020

Uh oh!

sthaha commented Oct 19, 2020

Uh oh!

sthaha commented Oct 20, 2020

Uh oh!

danielhelfand left a comment

Uh oh!

Uh oh!

Uh oh!

piyush-garg commented Oct 21, 2020

Uh oh!

tekton-robot commented Oct 22, 2020

Uh oh!

danielhelfand left a comment

Uh oh!

danielhelfand Oct 22, 2020

Uh oh!

danielhelfand Oct 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -0,0 +1,46 @@
		## tkn hub get pipeline

		Get pipeline by name, catalog and version

		@@ -0,0 +1,46 @@
		## tkn hub get task

		Get task by name, catalog and version

Conversation

sthaha commented Oct 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Submitter Checklist

Release Notes

Uh oh!

sthaha commented Oct 19, 2020

Uh oh!

sthaha commented Oct 19, 2020

Uh oh!

sthaha commented Oct 20, 2020

Uh oh!

danielhelfand left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

piyush-garg commented Oct 21, 2020

Uh oh!

tekton-robot commented Oct 22, 2020

Uh oh!

danielhelfand left a comment

Choose a reason for hiding this comment

Uh oh!

danielhelfand Oct 22, 2020

Choose a reason for hiding this comment

Uh oh!

danielhelfand Oct 22, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sthaha commented Oct 14, 2020 •

edited

Loading