tkn pr describe failing in pr with conditions#1207
Merged
tekton-robot merged 1 commit intotektoncd:masterfrom Oct 20, 2020
Merged
tkn pr describe failing in pr with conditions#1207tekton-robot merged 1 commit intotektoncd:masterfrom
tekton-robot merged 1 commit intotektoncd:masterfrom
Conversation
tekton-robot
added
the
release-note
tekton-robot
added
the
size/L
This will fix the issue of tkn pr desc failing in case of pipelinerun with conditions and condition is not executed Add test Fix tektoncd#1204
Contributor
Author
|
/retest |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
piyush-garg
added a commit
that referenced
this pull request
Oct 21, 2020
#1194 | [Daniel Helfand] update README to v0.13.0 | 2020/09/30-22:18 #1196 | [Chmouel Boudjnah] Update OSX instruction to install from brew 🍻 | 2020/10/02-11:36 #1197 | [Daniel Helfand] reorganize release process docs and add details | 2020/10/07-07:26 #1192 | [Daniel Helfand] add eventlistener logs command | 2020/10/07-08:00 #1198 | [Matt Moore] Bump Knative/K8s dependencies | 2020/10/08-00:34 #1201 | [Daniel Helfand] avoid use of previous TaskRunSpecStatus and PipelineRunSpecStatus | 2020/10/13-17:32 #1205 | [Daniel Helfand] remove assertions to help with debugging eventlistener e2e failures | 2020/10/20-07:27 #1207 | [Piyush Garg] tkn pr describe failing in pr with conditions | 2020/10/20-08:57 #1189 | [Daniel Helfand] refactor pipelinerun and taskrun cancel err based on condition status | 2020/10/20-09:15 #1189 | [Daniel Helfand] add pipelinerun and taskrun cancel e2e tests | 2020/10/20-09:15 null | [Daniel Helfand] common way of referring to tekton resources in user facing messages: EventListener | 2020/10/21-07:21 null | [Daniel Helfand] common way of referring to tekton resources in user facing messages: TriggerBinding | 2020/10/21-08:00 Signed-off-by: Piyush Garg <pgarg@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix the issue of tkn pr desc failing
in case of pipelinerun with conditions
and condition is not executed
Add test
Fix #1204
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes