Skip to content

Common Way of Referring to Tekton Resources in User Facing Messages: ClusterTriggerBinding #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tekton-robot merged 1 commit into from
Oct 21, 2020
Merged

Common Way of Referring to Tekton Resources in User Facing Messages: ClusterTriggerBinding #1210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/cmd/tkn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ CLI for tekton pipelines
### SEE ALSO

* [tkn clustertask](tkn_clustertask.md) - Manage ClusterTasks
* [tkn clustertriggerbinding](tkn_clustertriggerbinding.md) - Manage clustertriggerbindings
* [tkn clustertriggerbinding](tkn_clustertriggerbinding.md) - Manage ClusterTriggerBindings
* [tkn completion](tkn_completion.md) - Prints shell completion scripts
* [tkn condition](tkn_condition.md) - Manage conditions
* [tkn eventlistener](tkn_eventlistener.md) - Manage eventlisteners
Expand Down
10 changes: 5 additions & 5 deletions docs/cmd/tkn_clustertriggerbinding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## tkn clustertriggerbinding

Manage clustertriggerbindings
Manage ClusterTriggerBindings

***Aliases**: ctb,clustertriggerbindings*

Expand All @@ -12,7 +12,7 @@ tkn clustertriggerbinding

### Synopsis

Manage clustertriggerbindings
Manage ClusterTriggerBindings

### Options

Expand All @@ -26,7 +26,7 @@ Manage clustertriggerbindings
### SEE ALSO

* [tkn](tkn.md) - CLI for tekton pipelines
* [tkn clustertriggerbinding delete](tkn_clustertriggerbinding_delete.md) - Delete clustertriggerbindings
* [tkn clustertriggerbinding describe](tkn_clustertriggerbinding_describe.md) - Describes a clustertriggerbinding
* [tkn clustertriggerbinding list](tkn_clustertriggerbinding_list.md) - Lists clustertriggerbindings in a namespace
* [tkn clustertriggerbinding delete](tkn_clustertriggerbinding_delete.md) - Delete ClusterTriggerBindings
* [tkn clustertriggerbinding describe](tkn_clustertriggerbinding_describe.md) - Describes a ClusterTriggerBinding
* [tkn clustertriggerbinding list](tkn_clustertriggerbinding_list.md) - Lists ClusterTriggerBindings in a namespace

6 changes: 3 additions & 3 deletions docs/cmd/tkn_clustertriggerbinding_delete.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## tkn clustertriggerbinding delete

Delete clustertriggerbindings
Delete ClusterTriggerBindings

***Aliases**: rm*

Expand All @@ -12,7 +12,7 @@ tkn clustertriggerbinding delete

### Synopsis

Delete clustertriggerbindings
Delete ClusterTriggerBindings

### Examples

Expand Down Expand Up @@ -46,5 +46,5 @@ or

### SEE ALSO

* [tkn clustertriggerbinding](tkn_clustertriggerbinding.md) - Manage clustertriggerbindings
* [tkn clustertriggerbinding](tkn_clustertriggerbinding.md) - Manage ClusterTriggerBindings

6 changes: 3 additions & 3 deletions docs/cmd/tkn_clustertriggerbinding_describe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## tkn clustertriggerbinding describe

Describes a clustertriggerbinding
Describes a ClusterTriggerBinding

***Aliases**: desc*

Expand All @@ -12,7 +12,7 @@ tkn clustertriggerbinding describe

### Synopsis

Describes a clustertriggerbinding
Describes a ClusterTriggerBinding

### Examples

Expand Down Expand Up @@ -44,5 +44,5 @@ or

### SEE ALSO

* [tkn clustertriggerbinding](tkn_clustertriggerbinding.md) - Manage clustertriggerbindings
* [tkn clustertriggerbinding](tkn_clustertriggerbinding.md) - Manage ClusterTriggerBindings

8 changes: 4 additions & 4 deletions docs/cmd/tkn_clustertriggerbinding_list.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## tkn clustertriggerbinding list

Lists clustertriggerbindings in a namespace
Lists ClusterTriggerBindings in a namespace

***Aliases**: ls*

Expand All @@ -12,11 +12,11 @@ tkn clustertriggerbinding list

### Synopsis

Lists clustertriggerbindings in a namespace
Lists ClusterTriggerBindings in a namespace

### Examples

List all clustertriggerbindings:
List all ClusterTriggerBindings:

tkn clustertriggerbinding list

Expand Down Expand Up @@ -44,5 +44,5 @@ or

### SEE ALSO

* [tkn clustertriggerbinding](tkn_clustertriggerbinding.md) - Manage clustertriggerbindings
* [tkn clustertriggerbinding](tkn_clustertriggerbinding.md) - Manage ClusterTriggerBindings

4 changes: 2 additions & 2 deletions docs/man/man1/tkn-clustertriggerbinding-delete.1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

.SH NAME
.PP
tkn\-clustertriggerbinding\-delete \- Delete clustertriggerbindings
tkn\-clustertriggerbinding\-delete \- Delete ClusterTriggerBindings


.SH SYNOPSIS
Expand All @@ -15,7 +15,7 @@ tkn\-clustertriggerbinding\-delete \- Delete clustertriggerbindings

.SH DESCRIPTION
.PP
Delete clustertriggerbindings
Delete ClusterTriggerBindings


.SH OPTIONS
Expand Down
4 changes: 2 additions & 2 deletions docs/man/man1/tkn-clustertriggerbinding-describe.1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

.SH NAME
.PP
tkn\-clustertriggerbinding\-describe \- Describes a clustertriggerbinding
tkn\-clustertriggerbinding\-describe \- Describes a ClusterTriggerBinding


.SH SYNOPSIS
Expand All @@ -15,7 +15,7 @@ tkn\-clustertriggerbinding\-describe \- Describes a clustertriggerbinding

.SH DESCRIPTION
.PP
Describes a clustertriggerbinding
Describes a ClusterTriggerBinding


.SH OPTIONS
Expand Down
6 changes: 3 additions & 3 deletions docs/man/man1/tkn-clustertriggerbinding-list.1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

.SH NAME
.PP
tkn\-clustertriggerbinding\-list \- Lists clustertriggerbindings in a namespace
tkn\-clustertriggerbinding\-list \- Lists ClusterTriggerBindings in a namespace


.SH SYNOPSIS
Expand All @@ -15,7 +15,7 @@ tkn\-clustertriggerbinding\-list \- Lists clustertriggerbindings in a namespace

.SH DESCRIPTION
.PP
Lists clustertriggerbindings in a namespace
Lists ClusterTriggerBindings in a namespace


.SH OPTIONS
Expand Down Expand Up @@ -53,7 +53,7 @@ Lists clustertriggerbindings in a namespace

.SH EXAMPLE
.PP
List all clustertriggerbindings:
List all ClusterTriggerBindings:

.PP
.RS
Expand Down
4 changes: 2 additions & 2 deletions docs/man/man1/tkn-clustertriggerbinding.1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

.SH NAME
.PP
tkn\-clustertriggerbinding \- Manage clustertriggerbindings
tkn\-clustertriggerbinding \- Manage ClusterTriggerBindings


.SH SYNOPSIS
Expand All @@ -15,7 +15,7 @@ tkn\-clustertriggerbinding \- Manage clustertriggerbindings

.SH DESCRIPTION
.PP
Manage clustertriggerbindings
Manage ClusterTriggerBindings


.SH OPTIONS
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/clustertriggerbinding/clustertriggerbinding.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func Command(p cli.Params) *cobra.Command {
cmd := &cobra.Command{
Use: "clustertriggerbinding",
Aliases: []string{"ctb", "clustertriggerbindings"},
Short: "Manage clustertriggerbindings",
Short: "Manage ClusterTriggerBindings",
Annotations: map[string]string{
"commandType": "main",
},
Expand Down
2 changes: 1 addition & 1 deletion pkg/cmd/clustertriggerbinding/delete.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ or
c := &cobra.Command{
Use: "delete",
Aliases: []string{"rm"},
Short: "Delete clustertriggerbindings",
Short: "Delete ClusterTriggerBindings",
Example: eg,
Args: cobra.MinimumNArgs(0),
SilenceUsage: true,
Expand Down
11 changes: 4 additions & 7 deletions pkg/cmd/clustertriggerbinding/describe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import (
"context"
"fmt"
"io"
"os"
"text/tabwriter"
"text/template"

Expand Down Expand Up @@ -60,7 +59,7 @@ or
c := &cobra.Command{
Use: "describe",
Aliases: []string{"desc"},
Short: "Describes a clustertriggerbinding",
Short: "Describes a ClusterTriggerBinding",
Example: eg,
Annotations: map[string]string{
"commandType": "main",
Expand All @@ -75,8 +74,7 @@ or

output, err := cmd.LocalFlags().GetString("output")
if err != nil {
fmt.Fprint(os.Stderr, "Error: output option not set properly \n")
return err
return fmt.Errorf("output option not set properly: %v", err)
}

if output != "" {
Expand Down Expand Up @@ -122,7 +120,7 @@ func printClusterTriggerBindingDescription(s *cli.Stream, p cli.Params, ctbName

ctb, err := cs.Triggers.TriggersV1alpha1().ClusterTriggerBindings().Get(context.Background(), ctbName, metav1.GetOptions{})
if err != nil {
return fmt.Errorf("failed to get clustertriggerbinding %s: %v", ctbName, err)
return fmt.Errorf("failed to get ClusterTriggerBinding %s: %v", ctbName, err)
}

var data = struct {
Expand All @@ -138,8 +136,7 @@ func printClusterTriggerBindingDescription(s *cli.Stream, p cli.Params, ctbName
w := tabwriter.NewWriter(s.Out, 0, 5, 3, ' ', tabwriter.TabIndent)
tparsed := template.Must(template.New("Describe ClusterTriggerbinding").Funcs(funcMap).Parse(describeTemplate))
if err = tparsed.Execute(w, data); err != nil {
fmt.Fprintf(s.Err, "Failed to execute template \n")
return err
return fmt.Errorf("failed to execute template: %v", err)
}
return w.Flush()
}
10 changes: 5 additions & 5 deletions pkg/cmd/clustertriggerbinding/list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@ import (
)

const (
emptyMsg = "No clustertriggerbindings found"
emptyMsg = "No ClusterTriggerBindings found"
)

func listCommand(p cli.Params) *cobra.Command {
f := cliopts.NewPrintFlags("list")

eg := `List all clustertriggerbindings:
eg := `List all ClusterTriggerBindings:

tkn clustertriggerbinding list

Expand All @@ -50,7 +50,7 @@ or
c := &cobra.Command{
Use: "list",
Aliases: []string{"ls"},
Short: "Lists clustertriggerbindings in a namespace",
Short: "Lists ClusterTriggerBindings in a namespace",
Annotations: map[string]string{
"commandType": "main",
},
Expand All @@ -63,7 +63,7 @@ or

tbs, err := list(cs.Triggers, "")
if err != nil {
return fmt.Errorf("failed to list clustertriggerbindings: %v", err)
return fmt.Errorf("failed to list ClusterTriggerBindings: %v", err)
}

output, err := cmd.LocalFlags().GetString("output")
Expand All @@ -90,7 +90,7 @@ or
}

if err = printFormatted(stream, tbs, p); err != nil {
return fmt.Errorf("failed to print clustertriggerbindings: %v", err)
return fmt.Errorf("failed to print ClusterTriggerBindings: %v", err)
}
return nil

Expand Down
2 changes: 1 addition & 1 deletion ...md/clustertriggerbinding/testdata/TestClusterTriggerBindingDescribe_NonExistedName.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Error: failed to get clustertriggerbinding bar: clustertriggerbindings.triggers.tekton.dev "bar" not found
Error: failed to get ClusterTriggerBinding bar: clustertriggerbindings.triggers.tekton.dev "bar" not found
2 changes: 1 addition & 1 deletion ...tertriggerbinding/testdata/TestListClusterTriggerBinding-No_ClusterTriggerBindings.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
No clustertriggerbindings found
No ClusterTriggerBindings found