Skip to content

Remove EventListener Log Output Assertion from e2e Tests #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tekton-robot merged 1 commit into from
Nov 11, 2020
Merged

Remove EventListener Log Output Assertion from e2e Tests #1249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions test/e2e/eventListener/eventListener_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,18 @@ func TestEventListenerE2E(t *testing.T) {
t.Run("Get logs of EventListener", func(t *testing.T) {
res := tkn.MustSucceed(t, "eventlistener", "logs", elName, "-t", "1")

elPods, err := c.KubeClient.Kube.CoreV1().Pods(namespace).List(context.Background(), metav1.ListOptions{LabelSelector: "eventlistener=" + elName})
if err != nil {
t.Fatalf("Error getting pods for EventListener %s: %v", elName, err)
}

podNum := len(elPods.Items)
if podNum != 1 {
t.Fatalf("Should be one replica for EventListener but had %d replicas", podNum)
}

stdout := res.Stdout()
assert.Check(t, helper.ContainsAll(stdout, "github-listener-interceptor-el-github-listener-interceptor-", "Listen and serve on port 8080"))
assert.Check(t, helper.ContainsAll(stdout, "github-listener-interceptor-el-github-listener-interceptor-", elPods.Items[0].Name))
})

t.Logf("Scaling EventListener %s to 3 replicas in namespace %s", elName, namespace)
Expand All @@ -75,6 +85,6 @@ func TestEventListenerE2E(t *testing.T) {
res := tkn.MustSucceed(t, "eventlistener", "logs", elName, "-t", "1")
stdout := res.Stdout()

assert.Check(t, helper.ContainsAll(stdout, "github-listener-interceptor-el-github-listener-interceptor-", "Listen and serve on port 8080", elPods.Items[0].Name, elPods.Items[1].Name, elPods.Items[2].Name))
assert.Check(t, helper.ContainsAll(stdout, "github-listener-interceptor-el-github-listener-interceptor-", elPods.Items[0].Name, elPods.Items[1].Name, elPods.Items[2].Name))
})
}