Skip to content

Ignore --follow flag when TaskRun or PipelineRun is done#1250

Merged
tekton-robot merged 1 commit intotektoncd:masterfrom
devholic:devholic-patch-1
Dec 2, 2020
Merged

Ignore --follow flag when TaskRun or PipelineRun is done#1250
tekton-robot merged 1 commit intotektoncd:masterfrom
devholic:devholic-patch-1

Conversation

@devholic
Copy link
Copy Markdown
Contributor

@devholic devholic commented Nov 11, 2020 •
edited
Loading

Changes

I'm not sure this action is intended or not, but when --follow flag is given, reader tries to read live logs instead of available logs. This may confuses user to debug since live logs are not sorted in task order.

In this PR, reader will check if PipelineRun or TaskRun is done when follow flag is given and read available logs instead of live logs.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

`log` command will ignore `--follow` flag when given TaskRun/PipelineRun is done

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 11, 2020
@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 11, 2020
@tekton-robot
Copy link
Copy Markdown
Contributor

tekton-robot commented Nov 11, 2020

Hi @devholic. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pradeepitm12
Copy link
Copy Markdown
Contributor

pradeepitm12 commented Nov 11, 2020

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 11, 2020
@devholic
Copy link
Copy Markdown
Contributor Author

devholic commented Nov 12, 2020

/retest

@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 12, 2020
@piyush-garg
Copy link
Copy Markdown
Contributor

piyush-garg commented Nov 25, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020
chmouel
chmouel approved these changes Dec 1, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@chmouel chmouel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks 👍🏼🔥

@tekton-robot
Copy link
Copy Markdown
Contributor

tekton-robot commented Dec 1, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2020
@piyush-garg
Copy link
Copy Markdown
Contributor

piyush-garg commented Dec 1, 2020

/test pull-tekton-cli-integration-tests-0_10

@devholic
Copy link
Copy Markdown
Contributor Author

devholic commented Dec 1, 2020

/retest

@devholic
Ignore --follow flag when TaskRun or PipelineRun is done
e58f45f 
Currently, when --follow flag is given, reader tries to read live logs instead of available logs. This may confuses user to debug since live logs are not sorted in task order.
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@devholic
Copy link
Copy Markdown
Contributor Author

devholic commented Dec 1, 2020 •
edited
Loading

I rebased branch onto latest commit of master branch 🙂

@piyush-garg
Copy link
Copy Markdown
Contributor

piyush-garg commented Dec 2, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@tekton-robot tekton-robot merged commit fcf584d into tektoncd:master Dec 2, 2020
@devholic devholic deleted the devholic-patch-1 branch December 2, 2020 15:52
chmouel added a commit that referenced this pull request Dec 17, 2020
@chmouel
New version v0.15.0
14165a2 
#1260 | [vinamra28] Use goreleaser task from tektoncd/catalog | 2020/11/18-09:01
#1261 | [Pradeep Kumar] update README to v0.14.0 | 2020/11/18-12:25
#1259 | [Pratik Jagrut] Add --no-headers flag to tkn condition list command | 2020/11/25-12:19
#1257 | [Chmouel Boudjnah] Use debian/VERSION when building debian package | 2020/11/25-12:33
#1254 | [Pratik Jagrut] Add --no-headers flag to tkn triggerbinding list command | 2020/11/25-14:13
#1255 | [Pratik Jagrut] Add --no-headers flag to tkn triggertemplate list command | 2020/11/25-14:13
#1258 | [Pratik Jagrut] Add --no-headers flag to tkn eventlistener list command | 2020/11/25-15:11
#1178 | [Vincent Demeester] Basic execution plugin module 📟 | 2020/12/01-12:25
#1242 | [Daniel Helfand] allow --prefix-name and --timeout to be overrode when using --last or --use options | 2020/12/01-12:25
#1250 | [Sunghoon Kang] Ignore --follow flag when TaskRun or PipelineRun is done | 2020/12/02-15:28
null | [SM43] Bumps Hub CLI Dependency | 2020/12/16-12:32
null | [Matt Moore] Hoist an ActivityTimeout option. | 2020/12/16-18:26
null | [Pradeep Kumar] bump pipeline and triggers dep | 2020/12/17-07:47
null | [Daniel Helfand] remove --check shorthand and add global flags to version cmd | 2020/12/17-08:59

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chmouel chmouel chmouel approved these changes

@pradeepitm12 pradeepitm12 Awaiting requested review from pradeepitm12

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@chmouel chmouel

@piyush-garg piyush-garg

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@devholic @tekton-robot @pradeepitm12 @piyush-garg @chmouel