Makefile: remove darwin/386 from cross target 🌮#1252
Merged
tekton-robot merged 1 commit intotektoncd:masterfrom Nov 13, 2020
Merged
Makefile: remove darwin/386 from cross target 🌮#1252tekton-robot merged 1 commit intotektoncd:masterfrom
tekton-robot merged 1 commit intotektoncd:masterfrom
Conversation
Seems like go 1.15 doesn't support this GOOS/GOARCH pair anymore. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
tekton-robot
added
release-note
4 tasks
Member
|
/lgtm Looking Good! 🤙🏽 |
Member
Author
|
/retest |
danielhelfand
approved these changes
Nov 13, 2020
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielhelfand The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Seems like go 1.15 doesn't support this GOOS/GOARCH pair anymore.
Signed-off-by: Vincent Demeester vdemeest@redhat.com
/cc @chmouel @danielhelfand
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes