Add deletion scenario to e2e test#279
Conversation
|
Hi @16yuki0702. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
needs-ok-to-test
|
|
||
| # delete pipeline, pipelinerun, task, taskrun, and pipelineresource | ||
| run_test "delete pipeline" expect -c " | ||
| spawn tkn pipeline delete output-pipeline |
There was a problem hiding this comment.
Is it better to be more simple using -f flag??
There was a problem hiding this comment.
I think it's fine with -f but doing with -f is extra better , you can perhaps move a lot of it to a generic shell function to simplify it,
There was a problem hiding this comment.
you can perhaps move a lot of it to a generic shell function to simplify it,
thanks!! I'll try it.
There was a problem hiding this comment.
Hmm... Test conainter image seems not to have expect command so I fix to use -f flag for now.
I think we can choose another way to this like below, any ideas?
- find a way use another command that has the same functionality as the expect command. (but I have no idea for now sorry 😓)
- Include expect command in test container image (Could it?)
|
/ok-to-test |
tekton-robot
added
ok-to-test
|
Hmm… Is expect command not installed on e2e image? |
tekton-robot
added
size/S
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 16yuki0702, sthaha The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
#290 | [Chmouel Boudjnah] Add rainbow colouring of the steps | 2019/09/08-05:36 #292 | [danielhelfand] add SilenceUsage: true to root.go | 2019/09/08-22:11 #293 | [Carlos Santana] Update install instructions in readme to 0.3.1 | 2019/09/08-23:39 #279 | [16yuki0702] Add deletion scenario to e2e test | 2019/09/09-02:17 #279 | [16yuki0702] Fix to use -f flag | 2019/09/09-02:17 #300 | [Chmouel Boudjnah] Use a older version of thrift | 2019/09/09-08:48 #300 | [Chmouel Boudjnah] Don't run go mod vendor on every build | 2019/09/09-08:48 #301 | [Chmouel Boudjnah] E2E tests fixes | 2019/09/09-12:00 #303 | [danielhelfand] add taskrun describe command | 2019/09/10-02:15 #304 | [16yuki0702] Fix document typos | 2019/09/10-04:45 null | [Piyush Garg] Fix interactive prompt with --last | 2019/09/10-07:04 null | [16yuki0702] Add canceling feature to taskrun command | 2019/09/10-08:23 null | [Chmouel Boudjnah] Improve release script | 2019/09/11-10:35 null | [Sunil Thaha] Doc: Improve taskrun help example | 2019/09/12-02:09 null | [Piyush Garg] Fix -n not working with pipeline logs | 2019/09/12-02:23 null | [Piyush Garg] Show descriptive failure message | 2019/09/12-03:36 null | [danielhelfand] change error message returned by task for namespace | 2019/09/16-06:48 null | [Chmouel Boudjnah] Add a Tasrun to build rpm. | 2019/09/17-01:52 null | [Chmouel Boudjnah] Add information about copr rpm package repo in README | 2019/09/17-01:52 null | [Chmouel Boudjnah] Use khuram spec files which does a proper source build | 2019/09/17-01:52 null | [Chmouel Boudjnah] Update README with distros supported for dnf install | 2019/09/17-01:52 null | [Nikhil Thomas] Fix CI breakage | 2019/09/19-23:57 null | [Andrea Frittoli] Fix the logs command when creating a pipelinerun | 2019/09/20-01:57 null | [16yuki0702] Adding missing copyright header | 2019/09/23-04:47 null | [danielhelfand] correct copr package section typos | 2019/09/23-08:38 null | [danielhelfand] align pipeline describe output with other describe commands | 2019/09/24-04:58 null | [Chmouel Boudjnah] Add no colour option | 2019/09/24-05:24 null | [Chmouel Boudjnah] Disable nocolour test | 2019/09/24-05:24 null | [Chmouel Boudjnah] Generate documentation | 2019/09/24-05:24 null | [danielhelfand] align output with task describe command | 2019/09/24-05:36 null | [cappyzawa] fix misspell based on https://goreportcard.com/report/github.com/tektoncd/cli#misspell | 2019/09/24-06:20 null | [danielhelfand] add check to taskrun cancel for already executed taskrun | 2019/09/24-07:56 null | [Pradeep Kumar] Common method to get last run for a pipeline | 2019/09/24-08:17 null | [Pradeep Kumar] correts imports order | 2019/09/24-08:17 null | [Andrea Frittoli] Improve the error message on pipeline create | 2019/09/24-09:40 null | [Andrea Frittoli] Fix the logs command when creating a pipelinerun | 2019/09/24-09:40 null | [danielhelfand] add check to pipelinerun cancel for already executed pipelinerun | 2019/09/25-09:11 null | [Vincent Demeester] Bump tektoncd/pipeline to 0.7.x | 2019/09/25-10:02 null | [Vincent Demeester] bump github.com/AlecAivazis/survey/v2 to v2.0.4 | 2019/09/25-10:02 null | [Khurram Baig] Add Vendored Dependencies to RPM Spec | 2019/09/26-03:03 Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
7 participants
Changes
Add deletion scenario to e2e test #244
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
Release Notes