Add --no-headers to list subcommand for taskruns and pipelineruns#834
Merged
tekton-robot merged 2 commits intotektoncd:masterfrom Mar 31, 2020
Merged
Conversation
tekton-robot
added
the
size/M
Member
Author
|
/meow |
Contributor
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
waveywaves
force-pushed
the
799-no-headers-taskrun-pipelinerun
branch
3 times, most recently
from
718e159 to
633a46c
Compare
Member
Author
|
/assign @danielhelfand |
Member
Author
|
/unassign @danielhelfand |
Member
Author
|
/assign @chmouel |
waveywaves
force-pushed
the
799-no-headers-taskrun-pipelinerun
branch
from
633a46c to
be2bdff
Compare
tekton-robot
added
size/L
chmouel
reviewed
Mar 27, 2020
chmouel
reviewed
Mar 27, 2020
waveywaves
force-pushed
the
799-no-headers-taskrun-pipelinerun
branch
4 times, most recently
from
942746e to
8c1d434
Compare
Member
Author
|
/retest |
waveywaves
force-pushed
the
799-no-headers-taskrun-pipelinerun
branch
from
8c1d434 to
f798ac6
Compare
Member
Author
|
@chmouel let me know as this is ready to be approved if there are not any changes to be made. I would like to split this commit into multiple commits considering the number of changes. |
danielhelfand
suggested changes
Mar 30, 2020
Member
danielhelfand
left a comment
danielhelfand
left a comment
There was a problem hiding this comment.
Just some minor feedback. Otherwise, looks good.
waveywaves
force-pushed
the
799-no-headers-taskrun-pipelinerun
branch
from
f798ac6 to
8e3990d
Compare
waveywaves
force-pushed
the
799-no-headers-taskrun-pipelinerun
branch
2 times, most recently
from
a9dfd02 to
4d9e4ce
Compare
Member
Author
|
/test pull-tekton-cli-build-tests |
This commit adds the --no-headers flag to the taskrun list subcommand. The --no-headers flag will allow users to omit the column headers of the output for `tkn taskrun list` (command will be `tkn taskrun list --no-headers`) which will intern allow them to parse the output easily for their own use cases. Docs generated and included.
This commit adds the --no-headers flag to the pipelinerun list subcommand. The --no-headers flag will allow users to omit the column headers of the output for `tkn pipelinerun list` (command will be `tkn pipelinerun list --no-headers`) Docs generated and included.
waveywaves
force-pushed
the
799-no-headers-taskrun-pipelinerun
branch
from
4d9e4ce to
12395a8
Compare
Member
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: piyush-garg, pradeepitm12, waveywaves The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
partly fixes #799
Add
--no-headersflag tolistsubcommand for taskruns and pipelineruns.Note
In the future, will open PRs related to #799 #785 together. i.e. for PR related to task, pipeline will have changes wrt
--all-namespacesand--no-headersSubmitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes