Add tooling to generate OperatorHub release artifacts #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note
tekton-robot
added
the
size/XXL
3 tasks
nikhil-thomas
force-pushed
the
tools/operatorhub/artifacts
branch
2 times, most recently
from
de6d9f8 to
2166107
Compare
Member
Author
|
/retest |
nikhil-thomas
force-pushed
the
tools/operatorhub/artifacts
branch
3 times, most recently
from
8ca9311 to
ec5e69c
Compare
tekton-robot
added
the
needs-rebase
vdemeester
reviewed
Jun 14, 2021
nikhil-thomas
force-pushed
the
tools/operatorhub/artifacts
branch
from
ec5e69c to
a622fc2
Compare
tekton-robot
removed
the
needs-rebase
tekton-robot
added
the
needs-rebase
nikhil-thomas
force-pushed
the
tools/operatorhub/artifacts
branch
from
a622fc2 to
b28a9e3
Compare
tekton-robot
removed
the
needs-rebase
nikhil-thomas
force-pushed
the
tools/operatorhub/artifacts
branch
from
b28a9e3 to
85c3a21
Compare
tekton-robot
added
the
needs-rebase
nikhil-thomas
force-pushed
the
tools/operatorhub/artifacts
branch
from
85c3a21 to
dccbe36
Compare
tekton-robot
removed
the
needs-rebase
tekton-robot
removed
the
do-not-merge/work-in-progress
nikhil-thomas
force-pushed
the
tools/operatorhub/artifacts
branch
2 times, most recently
from
d02fbb4 to
32edae6
Compare
Member
Author
|
/test pull-tekton-operator-integration-tests |
vdemeester
reviewed
Sep 1, 2021
Member
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
- What do we gain by duplicating webhook and operator deployment (between kubernetes and openshift platform) ?
- Are files in
release-artifacts/bundle/{manifests, …}supposed to be in the git index ?
operatorhub/kubernetes/manifests/bases/tektoncd-operator.clusterserviceversion.template.yaml
Show resolved
Hide resolved
operatorhub/kubernetes/release-artifacts/bundle/manifests/config-logging_v1_configmap.yaml
Show resolved
Hide resolved
nikhil-thomas
force-pushed
the
tools/operatorhub/artifacts
branch
from
32edae6 to
e0bcb87
Compare
vdemeester
approved these changes
Sep 3, 2021
tekton-robot
added
the
approved
nikhil-thomas
force-pushed
the
tools/operatorhub/artifacts
branch
from
8352b17 to
c8b33ac
Compare
tekton-robot
added
the
needs-rebase
nikhil-thomas
force-pushed
the
tools/operatorhub/artifacts
branch
from
c8b33ac to
2ad7e92
Compare
Add bare minimum CSV base Add Kubernetes OpenShift overlay directories Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
Add common fields Add additional stubs
Add a make target to run `operator-sdk generate bundle` command and generate updated bundle for tektoncd operator Add necessary directory structure to organize kustomize bases and overlays Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
Add annotations, labels, and other additional metadata Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
Modify resources in `config/bases` and `/config/openshift` to make it work with operator bundle generation tools Modify `kustomization.yaml`(s) Add a csv template for generating release artifacts for OpenShift Signed-off-by: Nikhil Thomas <nikhilthomas1@gmail.com>
Improve the UX of commandline flags of the `bundle.py` Improve structure of `config.yaml` for bundle.py so that specification of images and their replace locations is more readable. Refactor script to make it more readable Add first set of generated bundle for kubernetes and openshift platforms Future Work: - write a Tekton Task (like TEP table checker) to ensure that latest version of bundles are pushed with each PR. - add this bundle generation tool as a Task in Operator release pipeline. Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
Modify webhook deployments manifests to make it work with csv generation. Update generate CSVs Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
Add a Makefile to run bundle generator tool in operatorhub/tools Add a script to install `operator-sdk` Add a first draft of README.md Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
nikhil-thomas
force-pushed
the
tools/operatorhub/artifacts
branch
from
2ad7e92 to
f25f165
Compare
tekton-robot
removed
the
needs-rebase
nikhil-thomas
force-pushed
the
tools/operatorhub/artifacts
branch
from
f25f165 to
2a3f377
Compare
Add a generated bundle for kubernetes platform. Add docs on the bundle generation tool and on bundle geration for kubernetes. Signed-off-by: Nikhil Thomas <nikthoma@redhat.com>
nikhil-thomas
force-pushed
the
tools/operatorhub/artifacts
branch
from
2a3f377 to
3bb89e3
Compare
Member
|
lgtm |
pradeepitm12
reviewed
Sep 6, 2021
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pradeepitm12, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add tooling to generate OperatorHub release artifacts
Modify resources in
config/basesand/config/openshiftto make itwork with operator bundle generation tools
Modify
kustomization.yaml(s)Add a csv template for generating release artifacts for Kubernetes
Add first set of generated bundle for kubernetes and openshift platforms
Future Work:
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes