Skip to content

Fix: Pruner Config resetting to default when set to null #3078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tekton-robot merged 1 commit into from
Dec 23, 2025
Merged

Fix: Pruner Config resetting to default when set to null #3078

tekton-robot merged 1 commit into from
Dec 23, 2025

Conversation

@pramodbindal
Copy link
Member

@pramodbindal pramodbindal commented Dec 9, 2025 •
edited
Loading

When HistoryLimit is set to null in tektonconfig then it resets back to 100
After this fix, value will be retained

This also fixes the issues of pruner config resetting to default on upgrade.
Now after upgrade pruner should retain the old config

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Dec 9, 2025
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 9, 2025
@anithapriyanatarajan
Copy link
Contributor

anithapriyanatarajan commented Dec 9, 2025

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 9, 2025
@anithapriyanatarajan
Copy link
Contributor

anithapriyanatarajan commented Dec 9, 2025

/retest

pratap0007
pratap0007 reviewed Dec 10, 2025
View reviewed changes
@pramodbindal pramodbindal force-pushed the pruner branch 2 times, most recently from 5f5b1cf to bd44863 Compare December 10, 2025 06:41
@pratap0007
Copy link
Contributor

pratap0007 commented Dec 10, 2025

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2025
@anithapriyanatarajan
Copy link
Contributor

anithapriyanatarajan commented Dec 11, 2025

@pramodbindal Attempt to upgrade from 0.77.x to the pr code base either results in pruner controller crashloop or configmap value not retained. Could you please assess the upgrade scenario once and confirm the outcome please. Thankyou

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2025
@anithapriyanatarajan
Copy link
Contributor

anithapriyanatarajan commented Dec 19, 2025

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2025
anithapriyanatarajan
anithapriyanatarajan previously requested changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@anithapriyanatarajan anithapriyanatarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pramodbindal DeepCopyInto is causing the issue I believe. Could you consider this to get past the crashloop issue. Thankyou

@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 22, 2025
@infernus01
Copy link
Member

infernus01 commented Dec 23, 2025

LGTM

@anithapriyanatarajan
Copy link
Contributor

anithapriyanatarajan commented Dec 23, 2025

/approve

@tekton-robot
Copy link
Contributor

tekton-robot commented Dec 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anithapriyanatarajan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [anithapriyanatarajan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2025
@anithapriyanatarajan
Copy link
Contributor

anithapriyanatarajan commented Dec 23, 2025

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2025
@anithapriyanatarajan
Copy link
Contributor

anithapriyanatarajan commented Dec 23, 2025

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2025
@anithapriyanatarajan
Copy link
Contributor

anithapriyanatarajan commented Dec 23, 2025

@dependabot rebase

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2025
@pramodbindal
Fix: Pruner Config resetting to default when set to null
76848f6 
When HistoryLimit is set to null in tektonconfig then it resets back to 100
After this fix value will be retained

This also fisxes the issues ot pruner confog resetting to default on upgrade.
Now after upgrade pruner should retain the old config

Restore Pre upgrade fucntions
@anithapriyanatarajan
Copy link
Contributor

anithapriyanatarajan commented Dec 23, 2025

/retest

@anithapriyanatarajan
Copy link
Contributor

anithapriyanatarajan commented Dec 23, 2025

//lgtm

@anithapriyanatarajan
Copy link
Contributor

anithapriyanatarajan commented Dec 23, 2025

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2025
@tekton-robot tekton-robot merged commit 774867c into tektoncd:main Dec 23, 2025
22 of 23 checks passed
@infernus01
Copy link
Member

infernus01 commented Dec 23, 2025

/cherry-pick release-v0.78.x

1 similar comment
@pramodbindal
Copy link
Member Author

pramodbindal commented Dec 23, 2025

/cherry-pick release-v0.78.x

@tekton-robot
Copy link
Contributor

tekton-robot commented Dec 23, 2025

✅ Cherry-pick to release-v0.78.x successful!

A new pull request has been created to cherry-pick this change to release-v0.78.x.

Please review and merge the cherry-pick PR.

@tekton-robot tekton-robot mentioned this pull request Dec 23, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbpavan mbpavan Awaiting requested review from mbpavan

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@anithapriyanatarajan anithapriyanatarajan Awaiting requested review from anithapriyanatarajan

@pratap0007 pratap0007 Awaiting requested review from pratap0007

Assignees

@pratap0007 pratap0007

@anithapriyanatarajan anithapriyanatarajan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pramodbindal @anithapriyanatarajan @pratap0007 @infernus01 @tekton-robot