Updates TektonConfig Controller to recreate components on deletion #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note
tekton-robot
added
the
size/S
Contributor
|
The following is the coverage report on the affected files.
|
tekton-robot
added
the
needs-rebase
PuneetPunamiya
force-pushed
the
handle-deletion
branch
from
b3e954b to
39e1dbe
Compare
tekton-robot
removed
the
needs-rebase
PuneetPunamiya
changed the title
tekton-robot
added
size/M
Contributor
|
The following is the coverage report on the affected files.
|
vinamra28
reviewed
Aug 12, 2021
PuneetPunamiya
force-pushed
the
handle-deletion
branch
from
39e1dbe to
57d317d
Compare
Contributor
|
The following is the coverage report on the affected files.
|
sm43
reviewed
Aug 16, 2021
sm43
reviewed
Aug 16, 2021
sm43
reviewed
Aug 16, 2021
|
|
||
| return clients.Update(context.TODO(), tdCR, metav1.UpdateOptions{}) | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
may be we should also check if an existing instance doesn't have an owner ref then update that instance
Member
Author
There was a problem hiding this comment.
Have updated the patch could you please take a look at it once
PuneetPunamiya
force-pushed
the
handle-deletion
branch
from
57d317d to
14a74c0
Compare
Contributor
|
The following is the coverage report on the affected files.
|
- This patch adds ownerReference and following informers in TektonConfig Controller
- Tetkton Addon Informer
- Tekton Dashboard Informer
- Tekton Pipeline Informer
- Tekton Trigger Informer
Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>
PuneetPunamiya
force-pushed
the
handle-deletion
branch
from
14a74c0 to
6813858
Compare
tekton-robot
added
size/L
Contributor
|
The following is the coverage report on the affected files.
|
Member
|
/lgtm |
Member
|
/lgtm |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhil-thomas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Tetkton Addon Informer
- Tekton Dashboard Informer
- Tekton Pipeline Informer
- Tekton Trigger Informer
Fixes: #249
Signed-off-by: Puneet Punamiya ppunamiy@redhat.com
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes