-
Notifications
You must be signed in to change notification settings - Fork 232
[OpenShift] Add triggers defaults in CR instead of transformers #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following is the coverage report on the affected files.
|
|
/lgtm |
8631197 to
455d730
Compare
|
The following is the coverage report on the affected files.
|
455d730 to
06a2ceb
Compare
|
The following is the coverage report on the affected files.
|
06a2ceb to
0aef7db
Compare
|
The following is the coverage report on the affected files.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |

Changes
Triggers now support
config-default-triggersconfigmap as part of this PR tektoncd/triggers#1182.PR introduced new attribute
triggerin TektonConfig so that user can change the value of service account using CR itself.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes