[OpenShift] Read version to add in rbac resources from env #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/S
savitaashture
approved these changes
Aug 23, 2021
tekton-robot
added
the
approved
vdemeester
approved these changes
Aug 23, 2021
tekton-robot
added
the
needs-rebase
Contributor
|
/hold |
tekton-robot
added
the
do-not-merge/hold
This reads the version from env to add as a label in rbac resources instead of hardcoding. so on each upgrade all rbac resources will get updated with new label. Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
sm43
force-pushed
the
read-version-from-env
branch
from
ca11974 to
6645cf7
Compare
tekton-robot
removed
lgtm
Member
Author
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pradeepitm12, savitaashture, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reads the version from env to add as a label in rbac resources
instead of hardcoding. so on each upgrade all rbac resources will
get updated with new label.
Signed-off-by: Shivam Mukhade smukhade@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes