Patch vendor/ apimachinery to work on 1.22 #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new field is there in k8s 1.22, name subresource in the managedfields. This proves to make knative based types to not be valid on 1.22 and above, making tektoncd/pipeline as well as any other component using knative/pkg to be broken on 1.22 and above. This also updates `./hack/update-deps.sh` scripts to apply any patches that would be in `hack/patches` but not committing them as it would be repeating the same commit over and over. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
tekton-robot
added
the
release-note
tekton-robot
added
the
size/M
Member
Author
|
/cc @sm43 @nikhil-thomas |
Member
|
/lgtm |
savitaashture
approved these changes
Aug 26, 2021
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: savitaashture The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
A new field is there in k8s 1.22, name subresource in the
managedfields. This proves to make knative based types to not be valid
on 1.22 and above, making tektoncd/pipeline as well as any other
component using knative/pkg to be broken on 1.22 and above.
This also updates
./hack/update-deps.shscripts to apply anypatches that would be in
hack/patchesbut not committing them as itwould be repeating the same commit over and over.
This is tektoncd/pipeline#4164 applied to
tektoncd/operatorSigned-off-by: Vincent Demeester vdemeest@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes