Removes the resources based on the profile set #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/M
PuneetPunamiya
force-pushed
the
handle-changing-profiles
branch
2 times, most recently
from
a7f0080 to
4297958
Compare
PuneetPunamiya
force-pushed
the
handle-changing-profiles
branch
from
4297958 to
556af31
Compare
Member
Author
|
/test pull-tekton-operator-integration-tests |
sm43
reviewed
Sep 2, 2021
PuneetPunamiya
force-pushed
the
handle-changing-profiles
branch
2 times, most recently
from
b4eb103 to
f13c6ab
Compare
This patch includes:
- When the Tekton Config profile is changed, based on the profile set
components are deleted
- For example:
* If the profile is changed from all to basic:
* In case of Kubernetes: Dashboard Component is deleted
* In case of Openshift: Addon Component is deleted
Fixes: tektoncd#358
Signed-off-by: Puneet Punamiya <ppunamiy@redhat.com>
PuneetPunamiya
force-pushed
the
handle-changing-profiles
branch
from
f13c6ab to
45c4933
Compare
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhil-thomas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Tekton Config profile is changed, based on the profile set
components are deleted
For example:
If the profile is changed from all to basic:
DashboardComponent is deletedAddonComponent is deletedFixes: #358
Signed-off-by: Puneet Punamiya ppunamiy@redhat.com
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes